- Issue created by @smustgrave
- First commit to issue fork.
- πͺπΈSpain rodrigoaguilera Barcelona
Look at this commit
https://git.drupalcode.org/project/drupal/-/commit/c70620dc49df2ca821857...and write similar guidance about where core tests(not in modules) should be located.
- πΊπΈUnited States ultimike Florida, USA
Is the following correct for core lib tests?
Unit tests: core/lib/tests/Drupal/Tests/Core (\Drupal\Tests\Core\)
Kernel tests: core/lib/tests/Drupal/KernelTests/ (\Drupal\KernelTests\Core\)
Functional tests: core/lib/tests/Drupal/FunctionalTests/ (\Drupal\FunctionalTests\Core\)
Functional Javascript tests: core/lib/tests/Drupal/FunctionalJavascriptTests/ (\Drupal\FunctionalJavascriptTests\Core\)-mike
- π¬π§United Kingdom alexpott πͺπΊπ
@ultimike if by core lib tests you mean testing things in
core/lib/Drupal/Core
then yes. Things are a bit messy though.\Drupal\FunctionalJavascriptTests\Ajax\AjaxCallbacksTest
is testing core stuff for example. And \Drupal\FunctionalJavascriptTests\Components\ComponentRenderTest is not aboutcore/lib/Drupal/Component
The unit test directory is probably the most sorted... where tests for
core/lib/Drupal/Core
live incore/tests/Drupal/Tests/Core
and tests forcore/lib/Drupal/Component
live incore/tests/Drupal/Tests/Component
- First commit to issue fork.
- Merge request !9647Added initial doc text to base tests classes for core tests classes location β (Open) created by mattlc
- πΊπΈUnited States ultimike Florida, USA
Tests are passing. Needs review.
-mike
- Status changed to Needs review
about 2 months ago 1:00am 24 October 2024 - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Requeued tests, added question about another possible enhancement we could add here
- πΊπΈUnited States smustgrave
Probably does need a rebase now, 150+ commits back, not that I think the comments will fail a test.
But there is also an open thread about more improvements and can't see a reason off the top of my head not to.
- π«π·France mattlc
Thank you @larowlan & @smustgrave for your comments.
I rebased on 11.x and added missing part for contrib modules in BuildTestBase class.
Moving issue to Needs review.
- π«π·France mattlc
I'm sorry, I don't know why functional tests do not pass.
As an example : Drupal\Tests\layout_builder\Functional\LayoutSection gives following error :Layout section formatter access β β Behat\Mink\Exception\ResponseTextException: The text "Hello test world" was not found anywhere in the text of the current page.
As it does not relates on this issue, I don't know how to get the whole test pipeline work.
- π³πΏNew Zealand quietone
@mattlc, thanks for rebasing this. Some of the tests often fail randomly, and this is what you have encountered. We keep track of the random fails and in this issue, π± [meta] Known intermittent, random, and environment-specific test failures Active . That is where anyone who wants to the challenge of fixing a randomly failing test can find one to work on.
I have restarted the failing tests and they have come back passing this time. You should also be able to restart the tests using the GitLab UI.
- πΊπΈUnited States smustgrave
Believe feedback has been addressed for this one.
- πΊπΈUnited States dww
Spotted one problem with existing docs right next to the ones we're adding in
core/tests/Drupal/Tests/UnitTestCase.php
. Should we fix those here or in a follow-up? - πΊπΈUnited States dww
I should have added: the new docs look great! Big improvement. Thanks for working on this!
- πΊπΈUnited States smustgrave
Thanks @dww! Believe feedback has been addressed.
- π¬π§United Kingdom alexpott πͺπΊπ
-
alexpott β
committed f54e0fc3 on 11.1.x
Issue #3462973 by mattlc, ultimike, smustgrave, dww, larowlan, alexpott...
-
alexpott β
committed f54e0fc3 on 11.1.x
-
alexpott β
committed 6025a148 on 11.x
Issue #3462973 by mattlc, ultimike, smustgrave, dww, larowlan, alexpott...
-
alexpott β
committed 6025a148 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.