Fixed #14 (& #15). CI is running.
Fixed phpcs and phpstan errors.
mattlc → changed the visibility of the branch 3368857-remove-duplication-from-form to hidden.
mattlc → changed the visibility of the branch 3368857-remove-duplication-from to hidden.
Just saw this. My bad.
I rework on it.
Sorry for that.
Hello,
Thank you @anand48, as discussed with both @nico059 and @ultimike at DC Bacelona Trait might be a better solution to keep a simple extension hierarchy.
I worked on the 3368857-remove-duplication-trait.
- minor code style issues fix
- rebased on 11.x
- force pushed to 3368857-remove-duplication-trait
So I think the MR to consider is 9792 from @nico059.
I set the status to Needs review.
I'm sorry, I don't know why functional tests do not pass.
As an example : Drupal\Tests\layout_builder\Functional\LayoutSection gives following error :
Layout section formatter access
┐
├ Behat\Mink\Exception\ResponseTextException: The text "Hello test world" was not found anywhere in the text of the current page.
As it does not relates on this issue, I don't know how to get the whole test pipeline work.
Thank you @larowlan & @smustgrave for your comments.
I rebased on 11.x and added missing part for contrib modules in BuildTestBase class.
Moving issue to Needs review.
mattlc → changed the visibility of the branch 3368857-remove-duplication-trait-rebased to hidden.
I tried to replace the abstract class by a trait in order to keep original class inheritance/interface implementation intact but the tests results are the same : the "Submit" button cannot be found by #14 stated failing tests.
Hello,
Sorry for answer delay.
Not sure to understand.
You want to strip entity wrapper ?
<article{{ attributes }}>
... the content of the node
</article>
becomes
... the content of the node
If you talk about the entity wrapper set in entity template, this module can't as it is only targeted to fields on a "per view mode" basis.
This may be easy to do in your theme by overriding entity template such as node.html.twig.
Regards.
Hi,
Thank you for this patch.
However it fails when content translation is not enabled in B.
As the code is directly in "ImportService", it should control more strictly the config sync between A and B.
I think that your code should be integrated in the language_fallback import processor and test if content translation is UP and active for current entity bundle.