- Issue created by @joachim
- 🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
Prem Suthar → made their first commit to this issue’s fork.
- Status changed to Needs review
5 months ago 12:34pm 19 July 2024 - Status changed to Needs work
5 months ago 1:08pm 19 July 2024 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
5 months ago 1:32pm 19 July 2024 - Status changed to Needs work
5 months ago 2:04pm 19 July 2024 - 🇬🇧United Kingdom joachim
Good start.
But we should keep the mention of hook_menu_local_tasks_alter().
Something like:
> Additionally, hook_menu_local_tasks_alter() can be used to alter local tasks dynamically before they are rendered.
- Status changed to Needs review
5 months ago 12:05pm 22 July 2024 - Status changed to Needs work
5 months ago 1:39pm 22 July 2024 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
5 months ago 6:02am 23 July 2024 - Status changed to Needs work
5 months ago 6:27am 23 July 2024 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- First commit to issue fork.
- Status changed to Needs review
5 months ago 9:59am 31 July 2024 - 🇮🇳India arunkumark Coimbatore
Back merged the 11.x core to the branch to resolve the Queue bot merge issue.
Moving to NR
- Status changed to RTBC
5 months ago 7:19pm 31 July 2024 - 🇺🇸United States smustgrave
Okay so this issue was created and tagged novice on the 17th. Novice issue are meant for new users
@Prem Suthar you picked it up less then 2 days later, and as mentioned before in several tickets your post history shows you can avoid novice issues in the future
@arunkumark same deal
Both please try to avoid novice issues unless they've sat there for a few weeks, which wasn't the case here.
Believe @joachim feedback was addressed though
- Status changed to Fixed
5 months ago 11:08pm 5 August 2024 - 🇫🇷France nod_ Lille
Committed and pushed 9678dc6468 to 11.x and 71bcc296f5 to 10.4.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.