- Issue created by @chrisfromredfin
- Assigned to Sourav_Paul
- Merge request !557Issue #3461037: Only show number of installs if non-zero → (Open) created by Sourav_Paul
- Issue was unassigned.
- Status changed to Needs review
about 2 months ago 10:44am 30 July 2024 - 🇮🇳India snehal-chibde
Hello @sourav_paul, I have reproduced the issue successfully.
I have tested MR 557 on the Drupal 10.3.1 version, Module version 2.0.x-dev.
The MR is applied cleanly.Test Result:
If a recipe has 0 installs, no span is added with text as '0 installs' which was appearing before.
Added a before and after screenshot of the same.Moving this to review state.
- Status changed to RTBC
about 1 month ago 7:59am 8 August 2024 - Status changed to Needs work
about 1 month ago 11:02am 13 August 2024 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Merge conflict in the generated file, needs to be re-compiled.
Shouldn't the IF statement only work on recipes? I would imagine for regular modules/themes it's valid to know there are 0 installs.
- 🇮🇳India Prashant.c Dharamshala
@BramDriesen
Currently, I think the recipes are being fetched from the local directory only which is
core/recipesand if that is the case then the number of installs would be either 1 or 0, which will not make sense in my opinion.Therefore I think it a good idea to not show this section at all in case of Recipes.
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Therefore I think it a good idea to not show this section at all in case of Recipes.
Yes sure, but I don't see that distinction being made in the code changes. I only see a counter check if 0 to hide it, meaning in my eyes this is for everything and not only recipes.
- 🇺🇸United States chrisfromredfin Portland, Maine
I actually would prefer that the behavior be the same across all, not just for recipes.
