- Issue created by @prem suthar
- First commit to issue fork.
- Status changed to Needs review
5 months ago 10:24am 8 July 2024 - Assigned to hetal.solanki
- Issue was unassigned.
- Status changed to Needs work
5 months ago 10:53am 8 July 2024 - ๐ฎ๐ณIndia hetal.solanki
i have tested MR 5 and i have found some error below:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig web/modules/contrib/entity_tracer-3459871/ - ๐บ๐ธUnited States rloos289
I will accept this, but please fix the Readme. The current MR fixed the line length in a weird way,
- Line 17 has a random indent
- Lines 18,19, and 36-39 end prematurely - Status changed to Needs review
5 months ago 8:03am 9 July 2024 - ๐ฎ๐ณIndia chandansha
please review i tryed to create new comment which will not look weird.
Thanks!! - ๐ฎ๐ณIndia abhiyanshu_rawat
abhiyanshu โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia abhiyanshu_rawat
I have thoroughly reviewed MR !5 and can confirm that it resolves all the PHPCS issues.
Excellent work on this! There are just a few minor updates needed in the README file to fully align with the standards.
For additional clarity, please refer to the attached screenshot.@rloos289 Kindly review it now. Thank you!
- Status changed to Fixed
4 months ago 4:38pm 10 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.