πŸ‡ΊπŸ‡ΈUnited States @rloos289

Account created on 3 December 2016, over 8 years ago
#

Merge Requests

Recent comments

πŸ‡ΊπŸ‡ΈUnited States rloos289

rloos289 β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States rloos289

Thanks for fixing and clarifying. Merged!

πŸ‡ΊπŸ‡ΈUnited States rloos289

Adding credits

πŸ‡ΊπŸ‡ΈUnited States rloos289

Thanks, I made some small language edits and removed the gitlab ci file. Merged!

πŸ‡ΊπŸ‡ΈUnited States rloos289

rloos289 β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States rloos289

Looks good, thanks for the fix!

πŸ‡ΊπŸ‡ΈUnited States rloos289

rloos289 β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States rloos289

Im curious how you got this error. I just tried with a fresh Drupal installation myself and it worked fine. The error and fix suggest that you have a site with an entity type that either doesn't have a label or the label isn't a string, both of which seem like incredible unlikely scenarios to me. I'm willing to accept the change regardless. However, please remove the gitlab-ci file. This module doesn't have any tests for it to run.

πŸ‡ΊπŸ‡ΈUnited States rloos289

Thanks folks. Merging and closing

πŸ‡ΊπŸ‡ΈUnited States rloos289

I will accept this, but please fix the Readme. The current MR fixed the line length in a weird way,
- Line 17 has a random indent
- Lines 18,19, and 36-39 end prematurely

πŸ‡ΊπŸ‡ΈUnited States rloos289

Thanks for the review folks. I've made the requested changes

πŸ‡ΊπŸ‡ΈUnited States rloos289

rloos289 β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States rloos289

Adding a missing single quote

Production build 0.71.5 2024