[1.0.x] Entity Tracer

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, please update the issue summary to give the link to the correct project link and the issue title to contain that project name.

To the reviewers

Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .
Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.

1. FILE: entity_tracer.info.yml

package: Custom

This line is used by custom modules created for specific sites. It is not a package name used for projects hosted on drupal.org.

core_version_requirement: ^8 || ^9 || ^10

The Drupal Core versions before 8.7.7 do not recognize the core_version_requirement: key.

2. FILE: entity_tracer.module

/**
 * @file
 * Primary module hooks for entity_tracer module.
 */

In Drupal, there are no primary and secondary hooks. The description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.

3. FILE: src/Tracer.php

  public function __construct(
   EntityFieldManagerInterface $entityFieldManager,
   EntityTypeManager $entityTypeManager,
   ConfigFactory $configFactory,
   CacheBackendInterface $cache,
   EntityTypeBundleInfoInterface $entityTypeBundleInfo,
   RouteProviderInterface $routeProvider,
  ) {

Drupal coding standards say function declarations are written on a single line, even if they exceed 80 characters.

4. FILE: src/EntityLabelTwigExtension.php

  /**
   * Constructs the extension object.
   *
   * @param \Drupal\entity_tracer\Tracer $entityTracer
   *   The entity tracer tracer.
   */
  public function __construct(Tracer $entityTracer) {

The documentation comment for constructors is not mandatory anymore, If it is given, the description must be Constructs a new [class name] object. where [class name] includes the class namespace.

Drupal coding standards say function declarations are written on a single line, even if they exceed 80 characters.

@vishal.kadam

Can you provide a link to the coding standard that states that ?

https://www.drupal.org/docs/develop/standards/php/php-coding-standards#:~:text=Line%20length%20and%20wrapping,-The%20following%20rules&text=In%20general%2C%20all%20lines%20of,allowed%20to%20exceed%2080%20characters.&text=Conditions%20should%20not%20be%20wrapped%20into%20multiple%20lines. →

@vishal.kadam
Thank you. I will note the highlighted text says "Conditions should not be wrapped into multiple lines." A function declaration is not a condition statement. A condition is part of a logic check, such as the example if() statements.

Function declarations are explicitly covered later in the document: https://www.drupal.org/docs/develop/standards/php/php-coding-standards#f... →

@cmlara Thank you for clarifying that and pointing me to the relevant section of the documentation.

Thanks for the review folks. I've made the requested changes

Remember to change status, when the project is ready to be reviewed. In this queue, projects are only reviewed when the status is Needs review.

Rest looks fine to me.

Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.

Thank you for your contribution!
I updated your account so you can now opt into security advisory coverage for any project you created and every project you will create.

These are some recommended readings to help you with maintainership:

• Dries → ' post on Responsible maintainers
• Maintainership →
• Git version control system →
• Issue procedures and etiquette →
• Maintaining and responding to issues for a project →
• Release naming conventions → .

You can find more contributors chatting on Slack → or IRC → in #drupal-contribute. So, come hang out and stay involved → !

Thank you for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.

I thank also the dedicated reviewers as well.

Automatically closed - issue fixed for 2 weeks with no activity.