'Display "@display" needs a selected search fields' message is confusing

Created on 1 July 2024, 2 months ago
Updated 6 August 2024, about 1 month ago

Problem/Motivation

The Entity Reference Views display plugin has a very confusing validation message: 'Display "@display" needs a selected search fields to work properly. See the settings for the Entity Reference list format.' (EntityReference.php#L224).

Grammatically, it baffles me. What is "a [singular] selected search fields [plural]"? Also, shouldn't "Entity Reference list" be in quotes since it's a technical term? (Otherwise you can't tell if it's supposed to be '"Entity Reference list" format' or '"Entity Reference" "list format"'.) I think that if I were an inexperienced user I wouldn't have any idea what was going on or how to fix it.

Steps to reproduce

Create a new View, add an "Entity Reference" display, and see the Error message, e.g., "Display "Entity Reference" needs a selected search fields to work properly. See the settings for the Entity Reference list format."

Proposed resolution

I think if we just quote the technical terms (i.e., field names) it will clear things up.

Remaining tasks

tbd

User interface changes

UI string.

<!-- <h3 id="summary-api-changes">API changes</h3> --><!-- <h3 id="summary-data-model-changes">Data model changes</h3> -->

Release notes snippet

πŸ“Œ Task
Status

Fixed

Version

10.4 ✨

Component
ViewsΒ  β†’

Last updated about 11 hours ago

Created by

πŸ‡ΊπŸ‡ΈUnited States TravisCarden

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024