Add input string to exception message thrown in createConnectionOptionsFromUrl()

@joachim target branch should be 11.x or 11.0.x?

11.x, according to https://www.drupal.org/about/core/blog/new-drupal-core-branching-scheme-... →

ankitv18 → changed the visibility of the branch 3457009-exception-message-thrown to hidden.

MR!8539 is ready for a review.

Hi, I've verified MR 8539 in Drupal 11.x.
The change aligns with the requirement outlined in the issue and works as expected.
Since the code quality hasn't changed, +1 to RTBC.
Thanks!

Thanks for working to improve the exception message!

Issues for Drupal should always have the 'proposed resolution' section complete and up to date as this is important information for reviewers and committers. I had updated that section.

The proposed new text uses the phrase 'badly formed', instead I think it would be simpler and clearer to say that it is 'invalid'. Plus, there are no instances of 'badly formed' in the code.

I have left a comment on the MR.

Thanks @quietone for reviewing the MR, I've updated as per suggestion.

Feedback appears to be addressed

Will note that the issue was tagged novice for newer users. And the issue was created just few weeks ago.

@ankitv18 based on your post history would definitely say probably have the skill set for non novice issues.

Now there is no official time frame around the tag but I say if it’s sat there for a month or two with no new user picking up its fair game.

Thanks

Thanks this look much better now.

Leaving at RTBC

Committed/pushed to 11.x and cherry-picked back through to 10.3.x, thanks!

catch → closed merge request !8539

Automatically closed - issue fixed for 2 weeks with no activity.