- Issue created by @joachim
- First commit to issue fork.
- Assigned to ankitv18
- ๐ฌ๐งUnited Kingdom joachim
- ๐ฎ๐ณIndia ankitv18
ankitv18 โ changed the visibility of the branch 3457009-exception-message-thrown to hidden.
- Merge request !8539Issue #3457009 "Exception message thrown createconnectionpptionsfromurl" โ (Closed) created by ankitv18
- Issue was unassigned.
- Status changed to Needs review
2 months ago 1:33pm 25 June 2024 - Status changed to RTBC
2 months ago 10:11am 26 June 2024 - ๐ฎ๐ณIndia VinmayiSwamy
Hi, I've verified MR 8539 in Drupal 11.x.
The change aligns with the requirement outlined in the issue and works as expected.
Since the code quality hasn't changed, +1 to RTBC.
Thanks! - Status changed to Needs work
2 months ago 1:47am 5 July 2024 - ๐ณ๐ฟNew Zealand quietone New Zealand
Thanks for working to improve the exception message!
Issues for Drupal should always have the 'proposed resolution' section complete and up to date as this is important information for reviewers and committers. I had updated that section.
The proposed new text uses the phrase 'badly formed', instead I think it would be simpler and clearer to say that it is 'invalid'. Plus, there are no instances of 'badly formed' in the code.
I have left a comment on the MR.
- Status changed to Needs review
2 months ago 3:09am 5 July 2024 - ๐ฎ๐ณIndia ankitv18
Thanks @quietone for reviewing the MR, I've updated as per suggestion.
- Status changed to RTBC
2 months ago 1:07am 8 July 2024 - ๐บ๐ธUnited States smustgrave
Feedback appears to be addressed
Will note that the issue was tagged novice for newer users. And the issue was created just few weeks ago.
@ankitv18 based on your post history would definitely say probably have the skill set for non novice issues.
Now there is no official time frame around the tag but I say if itโs sat there for a month or two with no new user picking up its fair game.
Thanks
- ๐ณ๐ฟNew Zealand quietone New Zealand
Thanks this look much better now.
Leaving at RTBC
- ๐ฌ๐งUnited Kingdom catch
Committed/pushed to 11.x and cherry-picked back through to 10.3.x, thanks!
- Status changed to Fixed
about 1 month ago 8:53am 29 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.