Fix transltion string in ConfigFormBase.php

I have observed in core files (for eg. core/includes/errors.inc) instead of using translation t() can be use FormattableMarkup() (even same mentioned in MR where this issue trace out) , So replaced the t() with FormattableMarkup().

Please review , moving NR.

Can the issue summary be updated as well please.

Thanks

Made a small tweak to the comment, pulling from the issue summary, but change seems good to me. Function being protected assuming will be non disruptive to existing forms.

Rebased MR with latest code, seems working fine.

MR conflicts are visible on MR, addressed those

Rebased MR with latest code, seems working fine.

Added a comment to the MR.

Applied the mentioned suggestions.

Please review, moving NR

Left a comment on MR.

Applied the mentioned suggestions.

Please review, moving NR

Applied the mentioned suggestions

Please review, moving NR.

Don't have a preference over MarkupInterface or \Stringable but only one is used

One comment on the comment. Also I think @alexpott might have been asking for a return value of MarkupInterface|Stringable?

Applied suggestion: MarkupInterface|\Stringable for return type

Please review , moving NR

That's my mistake @pooja_sharma. Think you had that before and had you change it as I interpreted it differently.

Only committing to 11.x since the change is very minor and results in an API widening.

Committed b014318 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

Ran into an issue with the the return type change, since I was developing a module using the latest version of core and copied the new return type hint.

When using the new return type in an override with a stable version of core <=11.0.5, the child class is returning a wider type than it's parent.
When using the old return type in an override with 11.x-dev, parent::formatMultipleViolationsMessage() returns a wider type than the child class.

For a module to maintain compatibility with older versions of core and not break if it calls the parent method which now returns Markup, it will need to change the value returned from its parent:

    $parent = parent::formatMultipleViolationsMessage($form_element_name, $violations);
    if ($parent instanceof TranslatableMarkup) {
      return $parent;
    }
    else {
      // phpcs:ignore Drupal.Semantics.FunctionT.NotLiteralString
      return $this->t((string) $parent);
    }

Once the module drops support for older versions of core, it can update its typehint and remove the extra code.

\Drupal\update\UpdateSettingsForm also needs its return type updated.

Opened 🐛 ConfigFormBase::formatMultipleViolationsMessage() return type change will cause error Active as a bug from this change.