- Issue created by @quietone
- First commit to issue fork.
- Merge request !8542issue/3456149: Fixed translation string in ConfigFormBase β (Open) created by pooja_sharma
I have observed in core files (for eg. core/includes/errors.inc) instead of using translation t() can be use FormattableMarkup() (even same mentioned in MR where this issue trace out) , So replaced the t() with FormattableMarkup().
Please review , moving NR.
- Status changed to Needs review
2 months ago 7:40pm 25 June 2024 - Status changed to Needs work
2 months ago 6:12pm 26 June 2024 - πΊπΈUnited States smustgrave
Can the issue summary be updated as well please.
Thanks
- Status changed to Needs review
2 months ago 7:03pm 26 June 2024 - Status changed to RTBC
2 months ago 1:36pm 1 July 2024 - πΊπΈUnited States smustgrave
Made a small tweak to the comment, pulling from the issue summary, but change seems good to me. Function being protected assuming will be non disruptive to existing forms.
MR conflicts are visible on MR, addressed those
Rebased MR with latest code, seems working fine.
- Status changed to Needs work
about 2 months ago 10:49am 11 July 2024 - π¬π§United Kingdom alexpott πͺπΊπ
Added a comment to the MR.
Applied the mentioned suggestions.
Please review, moving NR
- Status changed to Needs review
about 2 months ago 12:01pm 11 July 2024 - Status changed to Needs work
about 2 months ago 1:30pm 11 July 2024 - Status changed to Needs review
about 2 months ago 2:22pm 11 July 2024 Applied the mentioned suggestions.
Please review, moving NR
Applied the mentioned suggestions
Please review, moving NR.
- Status changed to RTBC
about 2 months ago 1:59pm 12 July 2024 - πΊπΈUnited States smustgrave
Don't have a preference over MarkupInterface or \Stringable but only one is used
- Status changed to Needs work
about 1 month ago 8:50am 29 July 2024 - π¬π§United Kingdom catch
One comment on the comment. Also I think @alexpott might have been asking for a return value of MarkupInterface|Stringable?
Applied suggestion: MarkupInterface|\Stringable for return type
Please review , moving NR
- Status changed to Needs review
about 1 month ago 11:23am 29 July 2024 - Status changed to RTBC
about 1 month ago 1:45pm 29 July 2024 - πΊπΈUnited States smustgrave
That's my mistake @pooja_sharma. Think you had that before and had you change it as I interpreted it differently.
- Status changed to Fixed
about 1 month ago 8:19am 30 July 2024 -
alexpott β
committed b0143182 on 11.x
Issue #3456149 by pooja_sharma, smustgrave, quietone, catch, alexpott:...
-
alexpott β
committed b0143182 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.