- @quietone opened merge request.
- Status changed to Needs review
13 days ago 5:04am 13 June 2024 - Status changed to RTBC
12 days ago 5:17pm 13 June 2024 - πΊπΈUnited States smustgrave
This one seems straightforward as it's adding the ignore line.
- Status changed to Needs work
9 days ago 10:16am 17 June 2024 - π¬π§United Kingdom alexpott πͺπΊπ
When I read the issue title I was like uhoh I hope I agree with the implementation of this rule by coder as some of coder's opinions are highly debatable. So I reviewed all the places where we are adding skips and I think this shows the value of the rule. There are things we would not have done in core if this rule was present - so that is great. However that means I think we should add follow-ups to address all these places where we are skipping the rule and should not be.
- Status changed to Needs review
4 days ago 12:36pm 21 June 2024 - π³πΏNew Zealand quietone New Zealand
Made lots of followups and committed the suggestions made in the MR. Setting back to NR.