- Issue created by @Tom Konda
- Merge request !8381Issue #3454079:Prefer to use Array.prototype.includes() for some of Array.prototype.indexOf() β (Closed) created by Tom Konda
- Status changed to Needs review
14 days ago 4:50am 12 June 2024 - Status changed to RTBC
12 days ago 2:43pm 13 June 2024 - πΊπΈUnited States smustgrave
Coming from π Use String.prototype.includes() instead of String.prototype.indexOf() where necessary Fixed this change already seemed to be accepted so this seems fine.
- Status changed to Needs work
12 days ago 3:09pm 13 June 2024 - Status changed to Needs review
10 days ago 5:43am 16 June 2024 - π―π΅Japan Tom Konda
I changed to simple else clause in my local environment, it seems to work correctly.
- Status changed to RTBC
8 days ago 3:56pm 17 June 2024 - πΊπΈUnited States smustgrave
Feedback fron @nod_ appears to be addressed.
- Status changed to Needs work
8 days ago 7:48pm 17 June 2024 - π«π·France nod_ Lille
Thanks for the update. When reviewing with the full context, it makes sense to have the else if, can you add it back please?
- Status changed to Needs review
7 days ago 4:27pm 18 June 2024 - Status changed to RTBC
7 days ago 5:25pm 18 June 2024 - Status changed to Fixed
7 days ago 8:31pm 18 June 2024 - π«π·France nod_ Lille
Committed and pushed 0819b7aaf4 to 11.x and 530cf173e4 to 11.0.x and 6f61856980 to 10.4.x. Thanks!