- Issue created by @rajeshreeputra
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
7 months ago Not currently mergeable. - last update
7 months ago 74 pass - last update
7 months ago 74 pass - First commit to issue fork.
- Status changed to Needs review
5 months ago 6:12am 25 July 2024 - First commit to issue fork.
- 🇮🇳India deepakkm
@chaitanyadessai please dont fix phpstan issues which are removed from Drupal 12 and if you are fixing them kindly fix the pipeline too. pipeline is now green and hence requesting review. Creating separated issue to fix phpstan and phpcs issues.
- First commit to issue fork.
- Status changed to Needs work
5 months ago 1:46pm 6 August 2024 - 🇦🇺Australia VladimirAus Brisbane, Australia
Thanks for commits. 🥳
Need to make surephpstan (next major)
is green. - 🇮🇳India vishalkhode
@VladimirAus I don't think we should fix PHPCS or PHPStan error as part of this ticket. We should limit this ticket to fix only Drupal 11 deprecation errors/warnings and failing PHPUnit tests.
Thanks for commits. 🥳
Need to make sure phpstan (next major) is green. - 🇦🇺Australia VladimirAus Brisbane, Australia
@vishalkhode depreciation errors and unknown functions errors from
phpstan (next major)
should be fixed. - 🇮🇳India vipin.mittal18 Greater Noida
I could not agree more with @vishalkhode more as coding standards issues should not be included in Drupal11 compatibility fixes. It should be fixed at separate ticket which I can see already created at https://www.drupal.org/project/config_update/issues/3465396 📌 Fix validate pipeline Needs review .
- Status changed to RTBC
5 months ago 9:15am 7 August 2024 - 🇮🇳India rajeshreeputra Pune
I see multiple deprecations with next major phpstan here and I think we should fix.
- 🇮🇳India deepakkm
there is already a seperate ticket 📌 Fix validate pipeline Needs review created to fix those as those deprecations are soft in phpunit 10.5 and will be removed from phpunit 11 .
- Status changed to Needs work
5 months ago 1:44am 8 August 2024 - 🇦🇺Australia VladimirAus Brisbane, Australia
Please see my comments above: we only need
phpstan (next major)
for D11 support. - 🇮🇳India deepakkm
@VladimirAus - i dont think we should fix the issues related to phpunit 11 here as those are shown in
phpstan (next major)
, but i would leave this call to maintainer whether that should be done here or not.
- 🇮🇳India deepakkm
The phpstan fixes are done here in a separate commit - https://www.drupal.org/project/config_update/issues/3465396 📌 Fix validate pipeline Needs review
- First commit to issue fork.
- 🇮🇳India ankitv18
ankitv18 → changed the visibility of the branch 3452453-drupal-11-support to hidden.
- Status changed to Needs review
4 months ago 11:50am 13 August 2024 - Status changed to RTBC
4 months ago 12:39pm 13 August 2024 -
vishalkhode →
committed fa39ca78 on 2.0.x authored by
ankitv18 →
Issue #3452453 by deepakkm, ankitv18, rajeshreeputra, VladimirAus,...
-
vishalkhode →
committed fa39ca78 on 2.0.x authored by
ankitv18 →
- Status changed to Fixed
4 months ago 1:54pm 13 August 2024 - 🇮🇳India vishalkhode
Thanks everyone for working on this. Looks good to me, Hence, merged.
Automatically closed - issue fixed for 2 weeks with no activity.