- Issue created by @Project Update Bot
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update theinfo.ymlfile for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-185727These packages were used to generate the fixes:
- drupal/upgrade_status: 4.3.1
- mglaman/phpstan-drupal: 1.2.11
- palantirnet/drupal-rector: 0.20.1
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update theinfo.ymlfile for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-188815These packages were used to generate the fixes:
- drupal/upgrade_status: 4.3.2
- mglaman/phpstan-drupal: 1.2.11
- palantirnet/drupal-rector: 0.20.2
- Status changed to Postponed
4 months ago 11:26am 3 June 2024 - 🇭🇺Hungary Balu Ertl Budapest 🇪🇺
Quoting from the output of the failing pipeline:
$ composer --version Composer version 2.7.6 2024-05-04 23:03:15 PHP version 8.3.7 (/usr/local/bin/php)Apparently the CI tries to install the module on an environment of PHP 8.3 while the issue of 🐛 PHP 8.2 compatibility RTBC is still open. Probably we may want merge that first, then this.
- 🇮🇳India rajeshreeputra Pune
@Balu may we proceed with implementing the changes outlined in 🐛 PHP 8.2 compatibility RTBC and commence with the work?
- Merge request !54Automated Project Update Bot fixes from run 11-188815. → (Merged) created by rajeshreeputra
- Status changed to Needs review
4 months ago 12:36pm 12 June 2024 - 🇮🇳India rajeshreeputra Pune
Created MR with required changes, hence requesting review.
- 🇮🇳India rajeshreeputra Pune
Rajeshreeputra → changed the visibility of the branch project-update-bot-only to hidden.
- First commit to issue fork.
- 🇮🇳India ankitv18
Dropped D9 as composer.json requires php-http/guzzle7-adapter
And php-http/guzzle7-adapter require guzzlehttp/guzzle ^7.0 Whereas drupal/core-recommended 9.5.11 requires guzzlehttp/guzzle ~6.5.8
Supporting D10.2 and as configFormBase introduce typedDataManger as argument in the constructor in D10.2.x and SettingsForm.php is trying to override the same property with same definition.
So to avoid code redundancy I only pushed 10.2 and 11 version of drupal for next release of this module. - Status changed to RTBC
4 months ago 9:42am 13 June 2024 - Status changed to Needs work
3 months ago 4:44pm 18 June 2024 - 🇺🇸United States japerry KVUO
Looking at the changes, IMHO the minimum should be 9.5.11 and not 10.2. There is no reason to artificially squeeze the compatibility window.
- Status changed to Needs review
3 months ago 6:58pm 18 June 2024 - 🇮🇳India ankitv18
Finally pipeline passed ~~ included 9.5 || 10 || 11 and also fixed the cspell job.
- 🇮🇹Italy itamair
I would be ok with this MR !54 (and merge it)
BUT I don't get why dependency injection was removed from the src/Form/SettingsForm.php
with all those changes that now would rely on:$typedConfigManager = \Drupal::service('config.typed');
I don't think this is required by Drupal 11,
and would revert all that, unless I am provide with clear motivation for that. - 🇮🇳India ankitv18
@itamair typedConfigManager passed as an argument from D10.2 in configFormBase class and settingsForm.php consists of config.factory and typed.config which is already passed as an argument in https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Form%21Co...
So as parent class already having those argument so I don't see any objective of repeating those property again and creating the instance with the same properties.
- Status changed to RTBC
3 months ago 5:50am 27 June 2024 - 🇮🇳India vipin.mittal18 Greater Noida
MR !54 is Drupal 11 compatible and working perfectly with Drupal 11 beta version.
-
itamair →
committed c2f2d17d on 8.x-4.x authored by
Rajeshreeputra →
Issue #3451105 by ankitv18, Rajeshreeputra, itamair: Automated Drupal 11...
-
itamair →
committed c2f2d17d on 8.x-4.x authored by
Rajeshreeputra →
- Status changed to Fixed
3 months ago 8:18pm 28 June 2024 - 🇮🇹Italy itamair
Thanks @ankitv18, makes sense (I wasn't aware of that 10.2 update).
MR !54 merged ... deploying new 8.x-4.24 with all this - 🇮🇹Italy itamair
@ankitv18 you are listed as first in the "by list" in the Commit message that merged the MR !54:
https://git.drupalcode.org/project/geocoder/-/commit/c2f2d17d9a9ddc598cc...as I checked your name (before the others) along merging it (with Pravin Gaikwad as author of the MR).
That's the only way I know to provide Issue Credits and that is instructed in the Drupal documentation:
https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett... →On my side there is nothing more to do on this.
Regards
Automatically closed - issue fixed for 2 weeks with no activity.