D11 Incompatibility: DependencySerializationTrait::__sleep signature changed

Created on 22 May 2024, 25 days ago

Problem/Motivation

The method signature for \Drupal\Core\DependencyInjection\DependencySerializationTrait::__sleep change, which is overridden by Facets in \Drupal\facets\Entity\Facet::__sleep.

We need to update it in Facets, since implementors must have the same return type.

Steps to reproduce

Run a commit past πŸ“Œ Fix remaining methods with #[\ReturnTypeWillChange] attribute RTBC (April 2024)

Run with Facets 2/3

Proposed resolution

Update the method signature, by adding `: array`

The change should be able to be committed now, as we can have a return type before DependencySerializationTrait does in earlier versions of core.

Remaining tasks

Update the return type.

User interface changes

API changes

Data model changes

πŸ“Œ Task
Status

Needs review

Version

2.0

Component

Code

Created by

πŸ‡¦πŸ‡ΊAustralia dpi Perth, Australia

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.69.0 2024