Fix remaining methods with #[\ReturnTypeWillChange] attribute

Had to add : void to one __wakeup() call that was being reported, from there I had to add it to all such methods otherwise they would not be covariant; by extension, I added : array to all __sleep() methods.

Applied the MR and searched the repo for "#[\ReturnTypeWillChange]" using phpstorm. All instances appear to be replaced and caused no test failures.

Added a fix for #3425337-21: Fix root namespace classes DebugClassLoader forward compatibility warnings →

Parent was reverted and is blocked on making PHP 8.3 the default CI environment

The implementation of the deprecation reporting in 📌 Upgrade PHPUnit to 10, drop Symfony PHPUnit-bridge dependency Fixed is now reporting about these missing fixes, that the current phpunit-bridge is not: https://git.drupalcode.org/issue/drupal-3417066/-/jobs/1012561

I think I can set this back to RTBC since the MR now is exactly as RTBCed in #4.

-  #[\ReturnTypeWillChange]
-  public function asort($flags = SORT_REGULAR): bool {
+  public function asort($flags = SORT_REGULAR): TRUE {

IIRC TRUE return type is PHP 8.2, so we should drop PHP 8.1 support first?

Yes it's PHP 8.2. But aren't we shipping D11 on PHP 8.3? Meaning, haven't we dropped PHP < 8.3 in the branch already? For sure we are testing on PHP 8.3 only.

We haven't technically done that until 📌 [11.x] [PP-1] Add PHP 8.3 requirement to Drupal 11.0.x Postponed lands although CI is PHP 8.3 only.

If we need to wait for #11 then ok; I wouldn't revert the MR change from bool to TRUE, since it would need to readd #[\ReturnTypeWillChange] to prevent PHP 8.3 to throw its own deprecation.

The blocker is in, this needs a rebase

Merged with 11.x, no conflicts. Back to RTBC.

Committed/pushed to 11.x, thanks!

Ignore the cherry-pick and revert, copy/pasted the wrong commit hash when cherry-picking another commit.

mondrake → closed merge request !6904

Automatically closed - issue fixed for 2 weeks with no activity.