- Issue created by @gauravvvv
- Status changed to Needs review
8 months ago 4:17am 21 May 2024 - Status changed to RTBC
8 months ago 5:39am 21 May 2024 - 🇮🇳India arunkumark Coimbatore
The fix seems to be straightforward. Tested the MR by manually using the grep command.
grep -r 'loading.gif' core
Before applying the patch.
After applying patch
- 🇬🇧United Kingdom catch
I checked where this was added (by running
git log -S loading.gif
) and it was in #610234: Overlay implementation → so was probably only ever used in the overlay module. - Status changed to Needs work
8 months ago 8:57am 21 May 2024 - 🇬🇧United Kingdom catch
However the test failure is real, needs more than just removing that line from the test.
https://git.drupalcode.org/issue/drupal-3448412/-/jobs/1640473
- Status changed to Needs review
8 months ago 3:06am 22 May 2024 - Status changed to RTBC
8 months ago 1:52pm 24 May 2024 - 🇺🇸United States smustgrave
Tests appear green and no searched core for core/misc/loading.gif but found nothing
Any concern that a contrib could be using this?
- 🇬🇧United Kingdom catch
There seems like a non-zero chance that contrib could be using this. We can't deprecate as such because there's nothing to deprecate, but could add a change record just in case, and only remove it from 11.0 (I think it's fine during beta since it's dead-not-even-code).
- Status changed to Needs work
8 months ago 6:52am 27 May 2024