- Issue created by @longwave
- Status changed to Needs review
6 months ago 11:33am 15 May 2024 - Status changed to RTBC
6 months ago 11:46am 15 May 2024 - π³πΏNew Zealand quietone
I applied the diff to 11.x and searched for 'removed from drupal:11.0' and get two results, in
- \Drupal\KernelTests\Core\Render\Element\DeprecatedElementTest::testBuildInfo
- \Drupal\element_info_test\Element\Deprecated
That is for testing that the deprecation process works for a deprecated render element.
- π¬π§United Kingdom longwave UK
In other tests of the deprecation process itself we use "is deprecated in drupal:X.0.0 and is removed from drupal:Y.0.0", maybe worth a followup to both make this consistent and make it easier to see which ones need to remain forever as they test the system itself.
- π³πΏNew Zealand quietone
I was thinking the same thing, so tagging for a followup. It's too late to do that now.
- π¬π§United Kingdom longwave UK
Opened π Use consistent fake versions for testing deprecations Active
- First commit to issue fork.
- π¬π§United Kingdom catch
Pushed one more commit to remove a bc layer for
chromeOptions
inPerformanceTestTrait
which didn't trigger its own deprecation because we already had one for the same thing elsewhere, but is no longer necessary once we don't support it. Trivial change so as long as gitlab comes back green I'll go ahead and commit this one once it has. - Status changed to Fixed
6 months ago 11:11am 18 May 2024 - π¬π§United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 11.0.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.