[PP-1] Not all UI elements are following rems scaling

Results

MR is ready for review. In #5 i have uploaded wrong gif with the demonstration of results. Will upload correct gif later, but you can test in any way.

I have updated leftover px value with variables.

RE #10
i'm attaching correct gif with the results

btw @Gauravvvv i think it is not required to change those px values, because if you will look to the context of the selector you will understand that the styles are used to hide visually an element.

Keeping on Needs review still

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

arunkumark → changed the visibility of the branch 11.x to hidden.

arunkumark → changed the visibility of the branch 3446611-ui-element to hidden.

Updated the fork and ready for Review.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Looks good to me, checked on all screen sizes and rem definitions.

Fixed 2 small bugs

1. scope of mobile expand button. now it is control-bar instead of top-bar
2. duplication of --admin-toolbar-top-bar-height variable in control-bar

That small bugs so i believe they can be applied as RTBC.

If possible i would like to postpone it.

📌 Migrate Toolbar button to SDC Needs review