Contrib.social

Add additional test coverage for DialogRenderer::getTitleAsStringable()

Open on Drupal.org →
Created on 6 May 2024, 4 months ago
Updated 5 September 2024, 3 days ago

Problem/Motivation

Follow up from 🐛 DialogRenderer::getTitleAsStringable() does not support all return types of TitleResolverInterface::getTitle() Fixed from @catch

I think we should have test coverage for the bug, but also I think we might want to open a dedicated issue for that and fix the regression before 10.3.0 beta so that various contrib aren't stuck with an unresolvable blocker. Bumping to critical and tagging as beta target.

Steps to reproduce

Create module in which in modulename.routing.yml file , add _title_callback
Add ajax link on any page that 'll be open in modal:
<a class="use-ajax" data-dialog-type="modal" href="/admin/content">Modal Page</a></p>
Here in the href of anchor tag goes the path of that page that defined in .routing file along with _titile_callback(key)

Proposed resolution

Add additional test coverage that covers that ticket

Remaining tasks

Implement
Review

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

📌 Task
Status

Fixed

Version

10.3 ✨

Component
Render  →

Last updated 2 days ago

Created by

🇺🇸United States smustgrave

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024