- Issue created by @hablat
- ๐บ๐ธUnited States hablat
I've added a patch that resolve the issue for us
- ๐บ๐ธUnited States hablat
We had to account for when the views area was added to the "No results behavior" section of the view. Adjusted the patch for this
- Status changed to Needs review
8 months ago 10:40pm 25 April 2024 - last update
8 months ago Custom Commands Failed - Status changed to Needs work
8 months ago 10:45pm 25 April 2024 The Needs Review Queue Bot โ tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request โ . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- last update
8 months ago 29,689 pass - First commit to issue fork.
- Merge request !8300Issue #3443586 View area displays even when parent view has no results. โ (Closed) created by prabha1997
- ๐บ๐ธUnited States xjm
@prabha1997, fixes should always start against the main 11.x branch. Thanks!
- ๐บ๐ธUnited States xjm
Weสปre actually better off simply creating a new MR, so doing that now.
- Merge request !8318Issue #3443586 View area displays even when parent view has no results. โ (Open) created by xjm
- Status changed to Needs review
7 months ago 11:55am 6 June 2024 - ๐บ๐ธUnited States xjm
OK, now reviewing the issue. Are we sure this isnสปt works as designed? Iสปve actually deliberately used this behavior sometimes, of having a global area to display when there are no results. I think this change might cause what appears to be a regression for some sites.
Tagging for subsystem maintainer review to decide if we actually want this change.
- Status changed to Needs work
7 months ago 11:59am 6 June 2024 - ๐บ๐ธUnited States xjm
The next step here is thorough manual testing of all the scenarios -- with and without view results, with and without the "display even if view has no results" checked. (Sounds like at least four total testing scenarios, which we should do before and after the patch.) We'll also need automated test coverage, probably a data provider to do exactly those scenarios above.
Thanks everyone!