Bump twig/twig to 3.9.0

Created on 17 April 2024, 2 months ago

Problem/Motivation

twig/twig Released v3.9.0.

In that version class Twig\NodeVisitor\AbstractNodeVisitor was deprecated and replaced by Twig\NodeVisitor\NodeVisitorInterface.
(https://twig.symfony.com/doc/3.x/deprecated.html#node-visitors)

Currently, when updating to twig/twig v3.9.0, GitLab CI grinds to a halt in the PHPStan phase with a cheery

 ------ --------------------------------------------------------------------- 
  Line   core/lib/Drupal/Core/Template/TwigNodeVisitor.php                    
 ------ --------------------------------------------------------------------- 
  21     Class Drupal\Core\Template\TwigNodeVisitor extends deprecated class  
         Twig\NodeVisitor\AbstractNodeVisitor:                                
         since 3.9 (to be removed in 4.0)                                     
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   core/lib/Drupal/Core/Template/TwigNodeVisitorCheckDeprecations.php   
 ------ --------------------------------------------------------------------- 
  21     Class Drupal\Core\Template\TwigNodeVisitorCheckDeprecations extends  
         deprecated class Twig\NodeVisitor\AbstractNodeVisitor:               
         since 3.9 (to be removed in 4.0)                                     
 ------ --------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------------------------- 
  Line   core/modules/help/tests/modules/help_topics_twig_tester/src/HelpTestTwigNodeVisitor.php  
 ------ ----------------------------------------------------------------------------------------- 
  20     Class Drupal\help_topics_twig_tester\HelpTestTwigNodeVisitor extends                     
         deprecated class Twig\NodeVisitor\AbstractNodeVisitor:                                   
         since 3.9 (to be removed in 4.0)                                                         
 ------ ----------------------------------------------------------------------------------------- 

(https://git.drupalcode.org/project/drupal/-/jobs/1347394#L33)

Steps to reproduce

Proposed resolution

- Bump twig/twig to 3.9.0 in composer.json and composer.lock
- Make suggested replacement to make PHPStan pass.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Closed: duplicate

Version

11.0 πŸ”₯

Component
BaseΒ  β†’

Last updated 1 minute ago

Created by

πŸ‡³πŸ‡±Netherlands Spokje

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.69.0 2024