Fix Media tests that rely on UID1's super user behavior

The ContentModerationTest made a distinction between the user 1 and an admin user. Therefore, all tests for rootUser were simply removed.

Seems like a good refactor.

I'm not sure about the changes to core/modules/media_library/tests/src/FunctionalJavascript/ContentModerationTest.php it seems to be testing user 1 specific stuff. I think we need to carefully think about why the user 1 tests are here because we have the admin user here already.

But with the addition of 📌 Add a container parameter that can remove the special behavior of UID#1 Fixed should we be testing user1 stuff?

I asked in Slack, #media, about why the test was specifically testing user #1. Two media maintainers, marcoscano and seanb responded saying that they saw no reason for it. seanb also said that they probably copied the test from somewhere else and then made it work for media.

So, I think it is OK to remove the specific assertions with user #1. Therefor restoring the RTBC.

nod_ → closed merge request !7555

nod_ → reopened merge request !7555

nod_ → credited marcoscano → .

nod_ → credited seanb → .

test failure that seems legit

Drupal\Tests\standard\FunctionalJavascript\StandardPerformanceTest::testStandardPerformance
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
     ],
     'CacheSetCount' => 45,
     'CacheDeleteCount' => 0,
-    'CacheTagChecksumCount' => 38,
-    'CacheTagIsValidCount' => 43,
+    'CacheTagChecksumCount' => 37,
+    'CacheTagIsValidCount' => 42,
     'CacheTagInvalidationCount' => 0,
     'CacheTagLookupQueryCount' => 21,
     'CacheTagGroupedLookups' => Array &2 [

core/tests/Drupal/Tests/PerformanceTestTrait.php:679
core/profiles/standard/tests/src/FunctionalJavascript/StandardPerformanceTest.php:175
core/profiles/standard/tests/src/FunctionalJavascript/StandardPerformanceTest.php:57

appears random 📌 Remove cache tag checksum assertions from performance tests Active

nod_ → closed merge request !7555

Committed 0948fc8 and pushed to 11.x. Thanks!