Remove cache tag checksum assertions from performance tests

Created on 5 March 2025, 4 days ago

Problem/Motivation

We have added better cache tag assertions over time, like CacheTagGroupedLookups.

These two don't actually give us useful performance information any more relative to the others, so I think we can just remove them from tests.

'CacheTagChecksumCount' => 38,
'CacheTagIsValidCount' => 43,

The actual data we might want to stop collecting and removing, but that should probably be its own issue and maybe major-only with a CR, not really a way to deprecate an array key.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

📌 Task
Status

Active

Version

11.0 🔥

Component

phpunit

Created by

🇬🇧United Kingdom catch

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @catch
  • 🇨🇭Switzerland berdir Switzerland

    > not really a way to deprecate an array key.

    Well, the array keys map to methods, so deprecating those should trigger deprecations.

    Possibly this is major/critical as it looks like StandardPerformanceTest has a new fairly frequent random fail?

  • 🇫🇷France andypost

    yesterday faced the same working on 📌 Remove UI and routes for the ability to update modules and themes via update.module and authorize.php Active
    ref https://git.drupalcode.org/issue/drupal-3502973/-/jobs/4561201
    basically it vary

        Standard Performance (Drupal\Tests\standard\FunctionalJavascript\StandardPerformance)
         ✘ Standard performance
           ┐
           ├ Failed asserting that two arrays are identical.
           ┊ ---·Expected
           ┊ +++·Actual
           ┊ @@ @@
           ┊      ],
           ┊      'CacheSetCount' => 45,
           ┊      'CacheDeleteCount' => 0,
           ┊ -····'CacheTagChecksumCount'·=>·38,
           ┊ -····'CacheTagIsValidCount'·=>·43,
           ┊ +····'CacheTagChecksumCount'·=>·37,
           ┊ +····'CacheTagIsValidCount'·=>·42,
           ┊      'CacheTagInvalidationCount' => 0,
           ┊      'CacheTagLookupQueryCount' => 21,
           ┊      'CacheTagGroupedLookups' => Array &2 [
           │
           │ /builds/issue/drupal-3502973/core/tests/Drupal/Tests/PerformanceTestTrait.php:679
           │ /builds/issue/drupal-3502973/core/profiles/standard/tests/src/FunctionalJavascript/StandardPerformanceTest.php:175
           │ /builds/issue/drupal-3502973/core/profiles/standard/tests/src/FunctionalJavascript/StandardPerformanceTest.php:57
  • Merge request !11386Resolve #3511123 "Remove cache tag assertions" → (Open) created by catch
  • Pipeline finished with Failed
    4 days ago
    Total: 97s
    #440834
  • 🇬🇧United Kingdom catch

    Bumping to critical due to the random test failures, I think all the places we're removing the deprecated methods are using the new better ones now.

  • 🇫🇷France andypost

    phpstan needs fixes

  • Pipeline finished with Success
    4 days ago
    Total: 294s
    #440882
  • 🇬🇧United Kingdom catch

    Green pipeline now.

  • 🇺🇸United States nicxvan

    Looks good to me.

    Checked deprecation messages.

    Read through the change record as well.

Production build 0.71.5 2024