- Issue created by @dww
- 🇫🇷France andypost
Routes probably should be deprecated as there's 📌 Support route aliasing (Symfony 5.4) and allow deprecating the route name Needs work
- 🇺🇸United States dww
I'm not so sure. 😅 For 📌 Remove adding an extension via a URL Fixed we removed the routes entirely, without deprecation. True, we didn't have a mechanism at the time, but from a release manager and framework manager standpoint, this stuff is so old, problematic, and presumably unused, that it's better to hide it from end users entirely than to keep the functionality visible (even if there are warnings).
- 🇫🇷France andypost
I think it ready for reviews
- forms and routes are removed
- subscriber no longer needed
- tests are cleaned/removed and somehow perf tests doing less
- mentions of routes/classes removed - 🇺🇸United States dww
Thanks for working on this! I should have mentioned all these changes could have been selectively merged into this fork from all the commits I pushed to the parent issue. Hope you didn't completely duplicate the effort. 😅
But thrilled to see progress here without me. 😉 I've been way too slammed on way too many fronts to work on this.
Thanks again!
-Derek - 🇺🇸United States smustgrave
Wasn't 100% how to review so I applied the MR and just searched for UpdateManagerUpdate and UpdateReady and think all trace is gone.
- 🇬🇧United Kingdom catch
The MR looks good to me, we can remove routes, forms and controllers in a minor release so it's successfully not breaking the bc policy despite being a disruptive change if anyone actually still uses this. However, definitely needs a change record and release note.
- 🇫🇷France andypost
rebased and pushed 2 more commits to remove remains of
_update_manager_access()
- 🇺🇸United States dww
Great, thanks!
Dare we mention any of the motivations in either the CR or release note? That composer is the only supported way to safely manage dependencies? And to pave the way for “automatic updates”? Although the wording / branding is going to be confusing with that, since the new thing is now being called “Update Manager” 😂
Also, I’m not sure we should say “drush or manual updates” in the CR. I thought we want to discourage “manual updates”, and I don’t think drush has a solution for this, either.
- 🇫🇷France andypost
download and update modules and themes through the web interface
using update manager UI)
- 🇨🇭Switzerland znerol
Nice! Good to see legacy code being removed. I'm impressed by the diff stat:
+9 −1291
. Automatically closed - issue fixed for 2 weeks with no activity.