Fix all tests that rely on UID1's super user behavior - Blocks

The issue title reads like this will be fixing all the tests, when it really is just those in content moderation. Maybe someth8ing like, "Fix content_moderation tests that rely on UID1's super user behavior"

Nice catch! Just changed. Will change the other issues too. Thanks for the remark!

pradhumanjain2311 → made their first commit to this issue’s fork.

pooja_sharma → changed the visibility of the branch 3439832-fix-content-moderation-test to hidden.

Addressed the superuser code needs to remove & added respective permissions.

Please review MR 8643, move NR

smustgrave → changed the visibility of the branch 11.x to hidden.

smustgrave → changed the visibility of the branch 3439832-fix-content-moderation to hidden.

Left some comments on the MR.

I have replied on the queries, Please review & passing for NR.

Saving credit for those who have worked on the issue thus far.

Left a response to the thread.

@smustgrave, I can't see new comment on MR, on the basis of prev comment , I 'm trying to reply on query:

Goal of ticket is adding permissions only, however permission can be assign to user only if module install code added before user login, if module install & respective config install (if required/added) code added after user login code in that case scenario permission can be assign only by adding role (checked in core as well)

Any other guidance/suggestion over it, not sure moving NR

Instead of creating a bunch of roles for single permissions

Why not move $this->setCurrentUser($this->adminUser); to below when the workflow is created and change to $this->setCurrentUser($this->createUser(['single permissiono']));

Should result in less calls being made.

Addressed the feedback, Please review, moving NR.

Had some threads I forgot to save from earlier that's my mistake.

Yeah I have similar thoughts, u didn't mention similar changes here then also skip from my end as well.

Applied suggestions, PLease review, moving NR.

Feedback appears to have been addressed

The diff does not apply to 11.x HEAD. And while does that I think it would make it easier to maintain if all the lists of permissions were sorted. Some of these in this MR are quite long. Thanks.

I don't know why but the diff applies now. The only commands I executed in my working directory was 'git log' and 'git status' . I'm restoring the status while I review.

Four of the functional tests extend from \Drupal\Tests\content_moderation\Functional\ModerationStateTestBase which defines a user and many permissions. Why are these four tests creating a new user with different permissions? Why not use the existing user and grant any permissions needed? It would simplify the tests.

Oh, and a reminder that we work collaboratively. Typically, there is no need to create a new branch and separate MR. Thanks.

Thanks for reviewing it, Verifying to address #28 📌 Fix Content Moderation tests that rely on UID1's super user behavior Active feedback.

Addressed #28 📌 Fix Content Moderation tests that rely on UID1's super user behavior Active feedback, sorry it was missed from my end, now code looks clean & tried to compare the old & changed generated test html files output - both are same.

Please review, moving NR.

Feedback appears to be addressed.

Committed and pushed 56186f9070b to 11.x and 743c2e68f70 to 11.1.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.