Umami page.tpl.php breaks block placeholders

Theoretically we have test coverage for this, but I don't think it's testing the right thing:

BlockViewBuilderTest::testBlockViewBuilderBuildAlter()

This was added all the way back in the original issue #2543340: Convert BlockViewBuilder to use #lazy_builder (but don't yet let context-aware blocks be placeholdered) → .

Got suspicious that only umami tests were failing, surely we had more block test coverage than this, and then looked at Umami's page.tpl.php and the bug is in there :(.

Postponing this on 📌 Use placeholdering for more elements to optimize asset serving Needs work since I'll include the fix in there, but leaving this open in case we want to split it out.

Did you mean core/profiles/demo_umami/themes/umami/templates/layout/page.html.twig?

It's not obvious to me what the problem is. I'd bet it's

{% if page.pre_header|render|striptags|trim is not empty or

which appears to be a work-around for 🌱 [meta] Themes improperly check renderable arrays when determining visibility Needs work ? 🫣

catch → changed the visibility of the branch 3439017-create-placeholder to hidden.

Extracted the commit from and put up an MR.

It's the strip tags that's the problem - placeholder HTML doesn't have any content outside the HTML tag, so Umami just discards it.

1) Drupal\FunctionalJavascriptTests\Ajax\AjaxTest::testAjaxFocus
    Failed asserting that two strings are equal.
    --- Expected
    +++ Actual

Seems unrelated to this change.

Question because I've similar code in the past. If you have debugging on then those conditions will now pass right? Due to the twig comments.

To quote @catch from slack

There are issues around to try to figure out render array emptiness Vs not, umami shouldn't be doing template hacks for it.

So my concern in #10 is mute.

Will mark.

nod_ → closed merge request !7896

Committed and pushed 1fd796042d to 11.x and a7a9469cdc to 11.0.x and a989b1dfc9 to 10.4.x and 8144350adb to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.