The calculated machine is not synced when the source value is defined and the machine name is empty.

I created an MR. I don't do any core development, so forgive me if I do something wrong.

The fix could be as simple as looking at the initial machine name and not the calculated machine name.

In 10.1.x, the code worked because the machine was being calculated via transliterate Ajax request which would set the target value after the event handler was initialized.

https://git.drupalcode.org/project/drupal/-/blob/10.2.x/core/misc/machin...
https://git.drupalcode.org/project/drupal/-/blob/10.1.x/core/misc/machin...

I hope this helps.

Thanks @jrockowitz! The only thing is that we need the MR to be created against 11.x, since issues are committed there first and then backported. Trying to switch the target branch can get really messy, so sometimes it's best to close the previous MR and re-create it against 11.x with a cherry-pick or whatever.

This also seems like a bug that should get some FunctionalJS test coverage, if it's a JS bug.

Thanks!

I added an assertion to MachineNameTest in a new D11 branch. I haven't added the fix created by @jrockowitz yet. That new assertion failed as expected. I'll commit the fix and see what happens.

Added info to the steps to reproduce. This is reproducible out-of-the-box with one of core's testing modules.

dcam → changed the visibility of the branch 3438739-calculated-machine-name to hidden.

Manually tested this following the steps.

Went to /form-test/machine-name
Changed the label and machine name did not change
Applying the MR and repeating
The machine name is changing

Summary seems to match the solution and has test coverage.

LGTM

This is a feature, not a bug.

Check out the 3 lines of comments just before the code change:

// Preview the machine name in realtime when the human-readable name
// changes, but only if there is no machine name yet; i.e., only upon
// initial creation, not when editing.

You want to be able to change the label without changing the machine name. Happens all the time that some vocabulary is renamed to be clearer to end-users but you want to keep the machine name to not mess with config export and custom code.

Saving credits according to our core issue credit guidelines → . Thanks!