- Issue created by @project update bot
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.
Therefore, these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-137198These packages were used to generate the fixes:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.10
- palantirnet/drupal-rector: 0.20.1
- Status changed to Needs work
9 months ago 5:44am 5 April 2024 - First commit to issue fork.
- Assigned to ivnish
- Issue was unassigned.
- Status changed to Needs review
4 months ago 9:09am 15 August 2024 - 🇩🇪Germany Anybody Porta Westfalica
@ivnish stop this please. PHPCS fixes are NOT part of such D11 compatibility issues. This is really uncool and unfriendly as it adds more work for the maintainers!
- First commit to issue fork.
- ivnish Kazakhstan
@anybody I asked Grevil first https://drupal.slack.com/archives/C1BMUQ9U6/p1723704842981339
- 🇩🇪Germany Grevil
@ivnish kindly asked if he could help getting this module ready for Drupal 11 and while he was at it asked, if any phpcs issues should get solved in the process.
I am fine with that, since the D11 compatibility problems weren't that many to begin with.
- 🇩🇪Germany Grevil
All tested and works like a charm! 😊👍
Especially the new Twig Function Syntax seemed pretty unconventional (changed made by rector patch bot), but works like charm! Even when overriding options!
Tested both the main module and the dynamic caption submodule. We can also jump from recommending photoswipe 5.4.2 to 5.4.4, which contains some minor bug fixes.
- Status changed to Needs work
4 months ago 10:13am 15 August 2024 - 🇩🇪Germany Grevil
Alright, did some more manual testing on the cdn integration, using 5.4.4, and dropped support for 5.4.1 (as some of our settings only apply when using at least 5.4.2).
That's it, merging! Thanks @ivnish!
- Status changed to RTBC
4 months ago 10:28am 15 August 2024 - Status changed to Needs work
4 months ago 10:39am 15 August 2024 - 🇩🇪Germany Grevil
Hm the next major tests fail, because of the "TwigFunction" change...
I am honestly confused, where this new syntax is coming from? Even in 11.x it isn't used yet (https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co...)... No idea where rector is coming up with that change...
I'll revert it again, and see what the pipeline says afterward.
- Status changed to RTBC
4 months ago 10:57am 15 August 2024 - 🇩🇪Germany Grevil
Ok, fully green again, what a weird change by rector and even weirder, that the twig function worked in my testing, but not for the next major release??
Oh well. Merging.
- Status changed to Fixed
4 months ago 10:58am 15 August 2024 - 🇩🇪Germany Grevil
Oh no, seems like the "merge commits" flag was turned off, all commits were pushed seperately...
Can not force push on any dev releases, I guess we have to live with that.
(https://git.drupalcode.org/project/photoswipe/-/commits/5.x?ref_type=heads)
- 🇩🇪Germany Grevil
Created a new release! https://www.drupal.org/project/photoswipe/releases/5.0.1 → .
- 🇩🇪Germany Grevil
@ivnish was your credit removed? I gave it to you, but it probably reset for some reason.
Well should be adjusted now. :)
Automatically closed - issue fixed for 2 weeks with no activity.