Contrib.social

Automated Drupal 11 compatibility fixes for inline_entity_form

Open on Drupal.org →
Created on 4 April 2024, 9 months ago
Updated 5 August 2024, 5 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

RTBC

Version

3.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @project update bot
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 9 months ago
    29 pass
  • Comment 9 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-137198

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.10
    3. palantirnet/drupal-rector: 0.20.1
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 7 months ago
    29 pass
  • Comment 7 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-188815

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.2
    2. mglaman/phpstan-drupal: 1.2.11
    3. palantirnet/drupal-rector: 0.20.2
  • Merge request !113Draft: Automated Project Update Bot fixes → (Open) created by project update bot
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 6 months ago
    Composer require failure
  • Comment 6 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-199781

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.2
    2. mglaman/phpstan-drupal: 1.2.11
    3. palantirnet/drupal-rector: 0.20.3
  • Merge request !114Automated Project Update Bot fixes → (Open) created by project update bot
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 6 months ago
    Composer require failure
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 6 months ago
    Composer require failure
  • Pipeline finished with Success
    6 months ago
    Total: 538s
    #201484
  • Pipeline finished with Success
    6 months ago
    #201483
  • Pipeline finished with Success
    6 months ago
    Total: 565s
    #201485
  • Comment 6 months ago →
    🇮🇳India vishalkhode

    vishalkhode → made their first commit to this issue’s fork.

  • Merge request !115Resolve #3438428 "Automated drupal 11" → (Merged) created by vishalkhode
  • Comment 6 months ago →
    🇮🇳India vishalkhode

    vishalkhode → changed the visibility of the branch project-update-bot-only to hidden.

  • Pipeline finished with Failed
    6 months ago
    Total: 540s
    #214679
  • Comment 5 months ago →
    🇮🇳India chandu7929 Pune

    Vishal, lets add next major CI as well to see what failing on D11

  • Pipeline finished with Failed
    5 months ago
    Total: 548s
    #232079
  • Pipeline finished with Failed
    5 months ago
    Total: 669s
    #232161
  • Pipeline finished with Failed
    5 months ago
    Total: 625s
    #232169
  • Status changed to Needs work 5 months ago
  • Comment 5 months ago →
    🇮🇳India chandu7929 Pune

    Need to fix failing test. Hence Needs work.

  • Comment 5 months ago →
    🇮🇱Israel jsacksick

    I think we should support D11 in the 3.x branch, that makes more sense to me so we can discontinue the 1.x branch.
    Thoughts here?

  • Pipeline finished with Success
    5 months ago
    Total: 531s
    #233174
  • Comment 5 months ago →
    🇮🇳India vishalkhode

    Hi @jsacksick
    Yes, that completely makes sense to me if we are planning to discontinue 1.x branch, then yes we shouldn't merge this in 1.x branch. I'm creating another MR against 3.x branch and let's see if all tests are passing, then you can go ahead review and merge the changes.

    I think we should support D11 in the 3.x branch, that makes more sense to me so we can discontinue the 1.x branch.

  • Comment 5 months ago →
    🇮🇳India chandu7929 Pune

    I think we should support D11 in the 3.x branch, that makes more sense to me so we can discontinue the 1.x branch

    I agree with you.

  • Comment 5 months ago →
    🇮🇳India chandu7929 Pune
  • Pipeline finished with Canceled
    5 months ago
    Total: 77s
    #233225
  • Pipeline finished with Success
    5 months ago
    #233228
  • Comment 5 months ago →
    🇮🇳India chandu7929 Pune

    Vishal, if we are panning to provide support from 8.8 then we should update CI to check on lower version as well.

  • Comment 5 months ago →
    🇮🇳India vishalkhode

    @chandu7929: The 3.x branch currently supports Drupal 8.8 and above, so I've not removed it as part of this ticket. I've just included the D11 support in the core_version_requirement from ^8.7.7 || ^9 || ^10 to ^8.8 || ^9 || ^10 || ^11. The reason of updating ^8.7.7 to ^8.8 to reflect it's same in the composer.json.

  • Pipeline finished with Success
    5 months ago
    Total: 845s
    #233241
  • Status changed to Needs review 5 months ago
  • Comment 5 months ago →
    🇮🇳India vishalkhode

    @jsacksick All tests are passing and CI is green now. Can you please review & merge the changes ?

  • Status changed to RTBC 5 months ago
  • Comment 5 months ago →
    🇮🇳India chandu7929 Pune

    The 3.x branch currently supports Drupal 8.8 and above, so I've not removed it as part of this ticket. I've just included the D11 support in the core_version_requirement from ^8.7.7 || ^9 || ^10 to ^8.8 || ^9 || ^10 || ^11. The reason of updating ^8.7.7 to ^8.8 to reflect it's same in the composer.json.

    ok, then lets include previous minor/major CI.

  • Status changed to Needs review 5 months ago
  • Comment 5 months ago →
    🇮🇳India chandu7929 Pune
  • Comment 5 months ago →
    🇮🇱Israel jsacksick

    None of the changes look like breaking changes, so we can probably make the changes in both branches actually. I said we should target 3.x without looking at the changes, my bad. Surprised these are the only changes required :).

    Let's address the points I raised, then we can merge this, though I haven't been actively maintaining IEF, so perhaps geek-merlin would like to do that?

  • Pipeline finished with Success
    5 months ago
    Total: 434s
    #233656
  • Comment 5 months ago →
    🇮🇳India chandu7929 Pune

    I think this is now ready for review. All CI green.

  • Pipeline finished with Success
    5 months ago
    Total: 519s
    #233683
  • Status changed to RTBC 5 months ago
  • Comment 5 months ago →
    🇮🇳India chandu7929 Pune

    Considering all test are passing. Hence RTBC.

  • Comment 5 months ago →
    🇮🇳India chandu7929 Pune

    @jsacksick → can you please merge and release this?

  • Comment 5 months ago →
    🇮🇳India chandu7929 Pune

    Hello @geek-merlin → Can you please help with merge and release this?

  • Comment 5 months ago →
    System Message
  • Comment 5 months ago →
    🇫🇷France andypost

    Somehow duplicate created 📌 Automated Drupal 11 compatibility fixes for inline_entity_form Needs review

  • Comment 5 months ago →
    🇺🇸United States dcam

    I've seen the bot make multiple issues for multiple branches of the same project. That's what happened here.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024