- Issue created by @atowl
- Merge request !3983437516 - Make chosen-single drop downs the same size as other drop downs → (Closed) created by atowl
- Assigned to atowl
- Status changed to Needs work
about 1 year ago 5:24pm 3 April 2024 - 🇮🇳India djsagar
Not able to reproduce this issue, Please provide More detail.
- Status changed to Needs review
about 1 year ago 11:28pm 3 April 2024 - 🇮🇳India ahsannazir
@atowl Can't we replace the padding value on the same class instead of shifting the padding values to the span?
- Merge request !4013437516 -Replace padding values to match form element. → (Merged) created by Unnamed author
- 🇳🇿New Zealand atowl
Hi @ahsannazir,
Yes, looks like that works as well. i think using the variable(s) --input-padding-vertical is better.
So the question now is really, which is more correct? to place the padding on the class itself or on the element within the class.
Happy either way, I'll let the maintainer decide. - 🇮🇳India ahsannazir
Yes @atowl both works. I'd prefer the original way like it was before. Replacing the values on the class itself
- Status changed to RTBC
12 months ago 2:21am 24 April 2024 - 🇳🇿New Zealand atowl
Changing status to reviewed and tested,
Maintainer can choose which fork they want to include. - 🇨🇦Canada chrisck BC, Canada
+1 to the approach that @ahsannazir used, I also prefer modifying the values on the original class, rather than applying them to the span tag. I've reviewed and tested MR !401.
- 🇨🇭Switzerland saschaeggi Zurich
saschaeggi → changed the visibility of the branch 3437516-improve-chosen-single-size to hidden.
Automatically closed - issue fixed for 2 weeks with no activity.