- Issue created by @smustgrave
- First commit to issue fork.
- Status changed to Needs work
9 months ago 8:39am 1 April 2024 - 🇮🇳India immaculatexavier
Created MR for the proposed resolution, But PHPUnit test fails.
- First commit to issue fork.
- Status changed to Needs review
9 months ago 2:48am 12 April 2024 - Status changed to RTBC
9 months ago 4:49pm 12 April 2024 - 🇺🇸United States smustgrave
Forgot about this one.
But refactoring seems fine and follows what was proposed in the original issue.
- Status changed to Needs work
9 months ago 8:05pm 12 April 2024 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
The new code seems to have duplicated a comment. Also I left a suggestion for further refactoring on the MR.
- Status changed to Needs review
9 months ago 12:17am 13 April 2024 - Status changed to RTBC
9 months ago 6:29pm 13 April 2024 - 🇺🇸United States smustgrave
Appears suggestion from #alexpott has been addressed.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed and pushed 4881479469 to 11.x and 6b2ecdbb73 to 10.3.x. Thanks!
- Status changed to Fixed
9 months ago 5:58am 14 April 2024 -
alexpott →
committed 6b2ecdbb on 10.3.x
Issue #3437178 by immaculatexavier, quietone, smustgrave, alexpott:...
-
alexpott →
committed 6b2ecdbb on 10.3.x
-
alexpott →
committed 48814794 on 11.x
Issue #3437178 by immaculatexavier, quietone, smustgrave, alexpott:...
-
alexpott →
committed 48814794 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.