Change the wording for the Top Bar checkbox

Created on 29 March 2024, 3 months ago
Updated 16 April 2024, 2 months ago

Problem/Motivation

The current checkbox to enable the Top Bar and the description it provides is confusing and doesn't give enough information to explain that it's an experimental feature, so the user knows what is enabling before doing so.

Steps to reproduce

Navigate to /admin/config/user-interface/navigation/settings.

Proposed resolution

Change the information so it is clear what this is enabling, and that it isn't finished and that it's experimental code.

Remaining tasks

  1. Choose how to change the text
  2. Change it

User interface changes

The text from the field to enable the top bar in the Navigation settings form will change.

๐Ÿ“Œ Task
Status

Fixed

Version

1.0

Component

Code

Created by

๐Ÿ‡ช๐Ÿ‡ธSpain ckrina Barcelona

Live updates comments and jobs are added and updated live.
  • Usability

    Makes Drupal easier to use. Preferred over UX, D7UX, etc.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @ckrina
  • ๐Ÿ‡ช๐Ÿ‡ธSpain ckrina Barcelona

    My first proposal:

    • Change the label from Hide Top Bar to Hide Experimental Top Bar
    • Change the description from The top bar is initially shown at the top of the page, click the checkbox to hide it.
      to The top bar is an experimental feature under active development that provides contextual controls.
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States benjifisher Boston area
  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany rkoller Nรผrnberg, Germany
  • ๐Ÿ‡ช๐Ÿ‡ธSpain ckrina Barcelona

    Adding credit to @rkoller and @benjifisher for bringing this up on Slack.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States KeyboardCowboy

    First, could we invert the behavior of the checkbox so Checked == On and Unchecked == Off to reduce the cognitive dissonance for the users? It feels counterintuitive to enable a checkbox to disable a feature.

    Here's my suggestion for the text:
    Label: "Hide Top Bar (experimental)"
    Description: "The Top Bar is an experimental feature that moves common administrative information and tasks on edit forms to the top of the page. This is part of a larger push to simplify and modernize the editorial interface."

  • First commit to issue fork.
  • Status changed to Needs review 3 months ago
  • ๐Ÿ‡ท๐Ÿ‡บRussia kostyashupenko Omsk

    By default disabled

  • Pipeline finished with Success
    3 months ago
    Total: 196s
    #134133
  • Status changed to Needs work 3 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Kanchan Bhogade

    Hi
    I've tested MR !213 on Drupal version 11.x
    Able to reproduce issues with the mentioned steps
    but the patch throws an error, please let me know if I'm missing anything

    Adding patch error screenshot for reference

  • Status changed to Needs review 3 months ago
  • ๐Ÿ‡ท๐Ÿ‡บRussia kostyashupenko Omsk

    Kanchan Bhogade, seems you have to git pull from 1.x first. The errors says that there is not file NavigationTopBarTest.php to patch, however this file is exist in 1.x https://git.drupalcode.org/project/navigation/-/blob/1.x/tests/src/Funct...

    Restoring needs review

  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany rkoller Nรผrnberg, Germany

    I've successfully applied MR213 against navigation 1.x-dev, havent run in any issue unable to reproduce the error experienced in #10 ๐Ÿ“Œ Change the wording for the Top Bar checkbox Needs review .

    I really like the change to invert the checkbox suggested by @keyboardcowboy in #6 ๐Ÿ“Œ Change the wording for the Top Bar checkbox Needs review . Also adding the term experimental in parenthesis to the checkbox label is good call.
    My only nitpick is about the description, in the current suggestion the first half of the first sentence is sort of redundant to the checkbox label. "The Top Bar is an experimental feature" is more or less repeating and only slightly rephrasing "Show Top Bar (experimental)". In regards of the second sentence "This is part of a larger push to simplify and modernize the editorial interface." I am not sure if this is very helpful for the user? I wonder if it would make more sense to articulate that the top bar doesnt provide the full functionality. the term experimental in the checkbox label communicates it is far from being finished but from my perspective the second sentence should also communicate hey the top bar will be placed there but dont be surpised that it doesnt contain the full functionality yet and might not that useful to you at the moment?

    A suggestion: Provides relevant administrative information and tasks for the respective page. It is not feature complete nor fully functional.

  • Status changed to Needs work 3 months ago
  • ๐Ÿ‡ช๐Ÿ‡ธSpain ckrina Barcelona

    Thanks @rkoller! Moving to Needs work to apply the suggestions.

  • Pipeline finished with Canceled
    3 months ago
    Total: 44s
    #135046
  • Status changed to Needs review 3 months ago
  • ๐Ÿ‡ท๐Ÿ‡บRussia kostyashupenko Omsk

    Done for #12

  • Pipeline finished with Success
    3 months ago
    Total: 211s
    #135047
  • Status changed to Fixed 3 months ago
  • ๐Ÿ‡ช๐Ÿ‡ธSpain ckrina Barcelona

    Added to the merge train. We can improve the wording later on but this leaves this field in a good shape for a stable release. Thanks all for the collaboration!

  • Pipeline finished with Success
    3 months ago
    Total: 240s
    #135095
  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Failed
    21 days ago
    Total: 140s
    #183071
  • Pipeline finished with Failed
    21 days ago
    Total: 242s
    #183069
  • Pipeline finished with Success
    21 days ago
    Total: 53s
    #183075
  • Pipeline finished with Success
    21 days ago
    Total: 52s
    #183076
Production build 0.69.0 2024