- Issue created by @ckrina
- ๐ช๐ธSpain ckrina Barcelona
My first proposal:
- Change the label from Hide Top Bar to Hide Experimental Top Bar
- Change the description from The top bar is initially shown at the top of the page, click the checkbox to hide it.
to The top bar is an experimental feature under active development that provides contextual controls.
- ๐บ๐ธUnited States benjifisher Boston area
ckrina โ credited benjifisher โ .
- ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
ckrina โ credited rkoller โ .
- ๐ช๐ธSpain ckrina Barcelona
Adding credit to @rkoller and @benjifisher for bringing this up on Slack.
- ๐บ๐ธUnited States KeyboardCowboy Denver, CO, USA
First, could we invert the behavior of the checkbox so Checked == On and Unchecked == Off to reduce the cognitive dissonance for the users? It feels counterintuitive to enable a checkbox to disable a feature.
Here's my suggestion for the text:
Label: "Hide Top Bar (experimental)"
Description: "The Top Bar is an experimental feature that moves common administrative information and tasks on edit forms to the top of the page. This is part of a larger push to simplify and modernize the editorial interface." - First commit to issue fork.
- Merge request !213Change the wording for the Top Bar checkbox โ (Merged) created by kostyashupenko
- Status changed to Needs review
9 months ago 5:47am 1 April 2024 - Status changed to Needs work
9 months ago 10:58am 1 April 2024 - ๐ฎ๐ณIndia Kanchan Bhogade
Hi
I've tested MR !213 on Drupal version 11.x
Able to reproduce issues with the mentioned steps
but the patch throws an error, please let me know if I'm missing anythingAdding patch error screenshot for reference
- Status changed to Needs review
9 months ago 11:28am 1 April 2024 - ๐ท๐บRussia kostyashupenko Omsk
Kanchan Bhogade, seems you have to git pull from 1.x first. The errors says that there is not file NavigationTopBarTest.php to patch, however this file is exist in 1.x https://git.drupalcode.org/project/navigation/-/blob/1.x/tests/src/Funct...
Restoring needs review
- ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
I've successfully applied MR213 against navigation 1.x-dev, havent run in any issue unable to reproduce the error experienced in #10 ๐ Change the wording for the Top Bar checkbox Needs review .
I really like the change to invert the checkbox suggested by @keyboardcowboy in #6 ๐ Change the wording for the Top Bar checkbox Needs review . Also adding the term experimental in parenthesis to the checkbox label is good call.
My only nitpick is about the description, in the current suggestion the first half of the first sentence is sort of redundant to the checkbox label. "The Top Bar is an experimental feature" is more or less repeating and only slightly rephrasing "Show Top Bar (experimental)". In regards of the second sentence "This is part of a larger push to simplify and modernize the editorial interface." I am not sure if this is very helpful for the user? I wonder if it would make more sense to articulate that the top bar doesnt provide the full functionality. the term experimental in the checkbox label communicates it is far from being finished but from my perspective the second sentence should also communicate hey the top bar will be placed there but dont be surpised that it doesnt contain the full functionality yet and might not that useful to you at the moment?A suggestion:
Provides relevant administrative information and tasks for the respective page. It is not feature complete nor fully functional.
- Status changed to Needs work
9 months ago 11:58am 1 April 2024 - ๐ช๐ธSpain ckrina Barcelona
Thanks @rkoller! Moving to Needs work to apply the suggestions.
- Status changed to Needs review
9 months ago 5:44am 2 April 2024 - Status changed to Fixed
9 months ago 7:15am 2 April 2024 - ๐ช๐ธSpain ckrina Barcelona
Added to the merge train. We can improve the wording later on but this leaves this field in a good shape for a stable release. Thanks all for the collaboration!
Automatically closed - issue fixed for 2 weeks with no activity.