Add validation constraints to system.logging

Seems straight forward. Not sure policy around managing lists like this (if there is one) but I've never seen this change.

So around the langcode change, seems related to 🐛 Require `langcode: …` only for simple config that contains translatable values Active

It is related but i think this landing independently shouldn't be a problem

Left some comments but don't think we need langcode added here as nothing is translated. Based on the other ticket that's the goal I believe so if we add here we will need to remove later and need an upgrade to do so.

While that might be true that the langcode shouldn't be added. I think it's a problem for another day, without the langcode being set now this won't pass tests and not be committed at all should we really block this on that?

Talking to @alexpott and @wim leers they mentioned we shouldn’t be adding langcode if not needed.

So if this can't pass core tests without it probably need to postpone it.

Just fyi the blocker for the langcode ticket is up for review too.

omkar.podey → changed the visibility of the branch 3436632-add-validation-constraints to hidden.

Tests passing, changes looks good to me. Moving to RTBC.

Let's block this on 📌 Allow parsing and writing PHP constants and enums in YAML files Needs work and then we can use the constants and we don't need a see as a comment.

yash.rode → made their first commit to this issue’s fork.

As it is in a good shape, we can get this merged and take care of the enum as a @todo?

yash.rode → changed the visibility of the branch 3436632-add-validation-constraints to active.

yash.rode → changed the visibility of the branch 3436632-add-validation-constraints-system-logging to hidden.

I think #27 is a valid point, as related issue is still in progress.

📌 Allow parsing and writing PHP constants and enums in YAML files Needs work is kinda stuck atm... let's go forward here - we can use constants / enums later.

Committed 1583842 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.