- Issue created by @omkar.podey
- Status changed to Needs review
5 months ago 10:28am 28 March 2024 - Status changed to RTBC
5 months ago 1:43pm 28 March 2024 - ๐บ๐ธUnited States smustgrave
Seems straight forward. Not sure policy around managing lists like this (if there is one) but I've never seen this change.
- Status changed to Needs work
5 months ago 1:58pm 28 March 2024 - Status changed to Needs review
5 months ago 6:19am 29 March 2024 - ๐บ๐ธUnited States smustgrave
So around the langcode change, seems related to ๐ Require `langcode: โฆ` only for simple config that contains translatable values Active
- ๐ฎ๐ณIndia omkar.podey
It is related but i think this landing independently shouldn't be a problem
- Status changed to Needs work
5 months ago 2:19pm 2 April 2024 - ๐บ๐ธUnited States smustgrave
Left some comments but don't think we need langcode added here as nothing is translated. Based on the other ticket that's the goal I believe so if we add here we will need to remove later and need an upgrade to do so.
- Status changed to Needs review
5 months ago 6:04am 4 April 2024 - ๐ฎ๐ณIndia omkar.podey
While that might be true that the langcode shouldn't be added. I think it's a problem for another day, without the langcode being set now this won't pass tests and not be committed at all should we really block this on that?
- ๐บ๐ธUnited States smustgrave
Talking to @alexpott and @wim leers they mentioned we shouldnโt be adding langcode if not needed.
- Status changed to Needs work
5 months ago 1:18pm 4 April 2024 - ๐บ๐ธUnited States smustgrave
So if this can't pass core tests without it probably need to postpone it.
- ๐บ๐ธUnited States smustgrave
Just fyi the blocker for the langcode ticket is up for review too.
- ๐ฎ๐ณIndia omkar.podey
omkar.podey โ changed the visibility of the branch 3436632-add-validation-constraints to hidden.
- Status changed to Needs review
5 months ago 5:47am 16 April 2024 - Status changed to RTBC
5 months ago 6:22am 16 April 2024 - ๐ฎ๐ณIndia narendraR Jaipur, India
Tests passing, changes looks good to me. Moving to RTBC.
- Status changed to Postponed
5 months ago 8:59am 16 April 2024 - ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
Let's block this on ๐ Allow parsing and writing PHP constants and enums in YAML files Needs work and then we can use the constants and we don't need a see as a comment.
- ๐ฎ๐ณIndia yash.rode pune
yash.rode โ made their first commit to this issueโs fork.
- Status changed to Needs review
about 2 months ago 11:33am 11 July 2024 - ๐ฎ๐ณIndia yash.rode pune
As it is in a good shape, we can get this merged and take care of the enum as a
@todo
? - Status changed to Needs work
about 2 months ago 11:40am 11 July 2024 - ๐ฎ๐ณIndia yash.rode pune
yash.rode โ changed the visibility of the branch 3436632-add-validation-constraints to active.
- ๐ฎ๐ณIndia yash.rode pune
yash.rode โ changed the visibility of the branch 3436632-add-validation-constraints-system-logging to hidden.
- Status changed to Needs review
about 2 months ago 12:27pm 11 July 2024 - Status changed to RTBC
about 2 months ago 5:53am 12 July 2024 - ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
๐ Allow parsing and writing PHP constants and enums in YAML files Needs work is kinda stuck atm... let's go forward here - we can use constants / enums later.
Committed 1583842 and pushed to 11.x. Thanks!
- Status changed to Fixed
about 1 month ago 9:52am 4 August 2024 -
alexpott โ
committed 15838422 on 11.x
Issue #3436632 by omkar.podey, yash.rode, Wim Leers, smustgrave: Add...
-
alexpott โ
committed 15838422 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.