Automated Drupal 11 compatibility fixes for workbench_email

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.9
3. palantirnet/drupal-rector: 0.20.1

@ankitv18: Looks like there are couple of deprecations that needs to be fixed. I think the warnings are coming because return type of methods not defined. Ex:

public function testDelivery($pluginId, array $expectedRecipients, array $settings = [], array $expectedDependencies = []) {

// It should be

public function testDelivery($pluginId, array $expectedRecipients, array $settings = [], array $expectedDependencies = []): void {

Can we add this in all methods of test and see if warnings are fixed ?

Deprecation warnings are basically from twig, doctrine and other drupal core packages,
example: The "Twig\Environment::getTemplateClass()" method is considered internal. It may change without further notice.
We can ignore these deprecations and will work once D11 have a stable release, please review MR!23

Review PR, changes looks good to me and also ran the tests in local and all are passing. The deprecations reported in "PHPUnit Next Major" are all related to Drupal core.

Hi
Which PR should I review here?

Thanks!

Hey @larowlan,
Please review MR!23 as it consists all the required changes for D11 compatiblity.

vishalkhode → changed the visibility of the branch project-update-bot-only to hidden.

Thanks will look at this later in the week

thanks folks

Automatically closed - issue fixed for 2 weeks with no activity.