- Issue created by @project update bot
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 8last update
11 months ago Waiting for branch to pass This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update theinfo.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-127659These packages were used to generate the fixes:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.9
- palantirnet/drupal-rector: 0.20.1
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 8last update
11 months ago Waiting for branch to pass - 🇨🇦Canada joseph.olstad
Going to combine the various D10 fixes, required by D11.
- 🇨🇦Canada joseph.olstad
PLEASE COMMIT/MERGE THE DRUPAL 11 FIX FOR the config_revision 📌 Automated Drupal 11 compatibility fixes for config_revision Needs review MODULE FIRST.
The config_revision module is required by webform_revision_ui however the automated tests will not load it as there is currently no advertised Drupal 11 compatible version of the config_revision module.
Chicken and the egg. First commit/merge this RTBC Drupal 11 fix.
📌 Automated Drupal 11 compatibility fixes for config_revision Needs review - 🇨🇦Canada joseph.olstad
I'll reach out to the maintainers (again?) to let them know we can merge.
- 🇨🇦Canada joseph.olstad
I sent friendly messages asking for D11 fix to these maintainers:
@Jibran
@mortim07
@nterbogt - 🇨🇦Canada jibran Toronto, Canada
The changes look good. Let's address some cosmetic comments, and then we are good to go.
- 🇺🇸United States smustgrave
Question what does adding permissions have to do with D11 release?
- 🇨🇦Canada joseph.olstad
@smustgrave, there's important fixes mixed in that affect/improve the automated testing that we have set up for the Drupal 11 upgrade.
Rather than unwind, would prefer we move forward with these.
- 🇨🇦Canada joseph.olstad
I'll check the test results in the morning, but I did test this last change locally and it worked.
- 🇨🇦Canada joseph.olstad
Please credit everyone from
🐛 Revisions tab shows up when the anonymous user accesses the Webforms Needs review
And
🐛 Use the magic method instead of "versionHistory" method from VersionHistoryController class Active
Please add credit for these contributors:
jamesyao , mohit_aghera , progga , smulvih2 , jibran - 🇨🇦Canada jibran Toronto, Canada
We need per operation to permission test.
we can't commit this until we add all the tests.
- 🇨🇦Canada joseph.olstad
@jibran, we're already testing anonymous and editor in new tests
https://git.drupalcode.org/project/webform_revision_ui/-/merge_requests/...
- 🇨🇦Canada jibran Toronto, Canada
Yes, we also need to test per permission and make sure all the operations are supported by newly added permissions.
- 🇮🇳India mohit_aghera Rajkot
mohit_aghera → changed the visibility of the branch project-update-bot-only to hidden.
- 🇮🇳India mohit_aghera Rajkot
mohit_aghera → changed the visibility of the branch project-update-bot-only to active.
- 🇮🇳India mohit_aghera Rajkot
Tests added for permissions https://git.drupalcode.org/project/webform_revision_ui/-/merge_requests/....
PR is green now. - 🇨🇦Canada joseph.olstad
Looks great, thanks! Any greener than this and you'd need to get a lawnmower to start cutting the grass.
- 🇨🇦Canada joseph.olstad
@jibran, it's literally perfect now, please review again!
- 🇨🇦Canada joseph.olstad
@jibran, please merge this Drupal 11 release fix and please also tag a release.
This module is one of our few remaining override modules and we'd prefer to normalize this situation.
Extensive testing has been performed over the past 2 months. No issues with this module running against Drupal 11.1.3.