- Status changed to RTBC
almost 2 years ago 6:41pm 20 January 2023 - 🇨🇦Canada jamesyao
Could someone please approve @mohit_aghera's merge request about adding permission?
- 🇨🇦Canada joseph.olstad
@jibran, let me repeat myself:
Test failure is unrelated to this functionality!
- 🇨🇦Canada joseph.olstad
please see
🐛 Fix webform_revision_ui head tests Needs work - 🇨🇦Canada joseph.olstad
@jibran, please trigger D9.5.x tests with a supported version of PHP
- 🇨🇦Canada joseph.olstad
Proof that the test fails have nothing to do with the above merge request:
I created a patch to add a README.md, the automated test failed
see results here: the no change patch is the second one from comment #4
I discovered the drupalci.yml was trying to apply a patch that's already been committed to the latest Drupal. A rerolled patch is required for tests to pass with Drupal 9.5.x, I'm testing a possible fix now
- 🇨🇦Canada jamesyao
Thanks @joseph.olstad for providing the root of the automation test failure cause about the merge request.
- 🇨🇦Canada joseph.olstad
I am stumped why the fails in config_revision and webform_revsion_ui , I necessarily updated the patch for the drupalci.yml to the expected patch but there's still errors. I'd appreciate it if someone else had a look at the config_revision issue
📌 Fix HEAD tests for config_revision for D9.5 Needs work
- 🇨🇦Canada joseph.olstad
Patch 3328890 from the merge request is still good! Holding status as RTBC
Thanks
- First commit to issue fork.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 8last update
10 months ago Waiting for branch to pass - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 8last update
10 months ago Waiting for branch to pass - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 8last update
10 months ago Waiting for branch to pass - Status changed to Needs review
10 months ago 6:51pm 12 January 2024 - 🇬🇧United Kingdom progga
Hello,
I am proposing an alternate fix where anybody who can edit a Webform would see its "Revisions" tab.Change summary:
- Permission fix for the "Revisions" tab. Associated functional test method.
- Had to add a Gitlab CI file as DrupalCI isn't running for some reason. Gitlab CI test is passing thankfully.
- Gitlab CI seems to require a composer.json file to grab dependencies. So had to add one.
- Some small fixes to cope with coding standard and static analysis checks.Please note that, with this change, just because someone has access to the revision history doesn't mean they could revert them. Please let me know if this approach is acceptable. Thanks.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 8last update
10 months ago Waiting for branch to pass - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 8last update
10 months ago Waiting for branch to pass