- Issue created by @Project Update Bot
- last update
8 months ago 7 pass, 4 fail This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.
Therefore these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-127659These packages were used to generate the fixes:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.9
- palantirnet/drupal-rector: 0.20.1
- last update
8 months ago 7 pass, 4 fail The last submitted patch, 2: subrequests.3.0.11.rector.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7last update
6 months ago Not currently mergeable. - First commit to issue fork.
- last update
6 months ago 7 pass, 4 fail - last update
6 months ago 7 pass, 4 fail - last update
6 months ago 5 pass, 5 fail - last update
6 months ago Composer require failure - last update
6 months ago Composer require failure - last update
6 months ago Composer require failure - last update
6 months ago Composer require failure - last update
6 months ago Composer require failure - last update
6 months ago Composer require failure - last update
6 months ago Composer require failure - last update
6 months ago Composer require failure - last update
6 months ago Composer require failure - last update
6 months ago Composer require failure - last update
6 months ago Composer require failure - last update
6 months ago Composer require failure - last update
6 months ago Composer require failure - last update
6 months ago Composer require failure - 🇮🇳India rajeshreeputra Pune
As of PHP 8.3 the function assert_options() and the assert.* directives are deprecated and should not be used in production code. To enable assertions PHP should be configured with zend.assertions.
Looking for alternative meanwhile requesting opinion from maintainer and community for the same.
- Status changed to Needs review
5 months ago 5:09am 5 June 2024 - Status changed to RTBC
5 months ago 5:36am 5 June 2024 - 🇮🇳India ankitv18
Apart from this deprecation https://git.drupalcode.org/issue/subrequests-3434821/-/jobs/1762586#L45, changes looks fine and can be merged as PHPunit pipelines are passing for all, hence moving into RTBC
- 🇮🇳India ankitv18
ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.
- Status changed to Needs review
5 months ago 4:15am 18 June 2024 - last update
5 months ago 7 pass, 4 fail This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.
Therefore, these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-199781These packages were used to generate the fixes:
- drupal/upgrade_status: 4.3.2
- mglaman/phpstan-drupal: 1.2.11
- palantirnet/drupal-rector: 0.20.3
- last update
5 months ago 7 pass, 4 fail The last submitted patch, 12: subrequests.3.x-dev.rector.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Status changed to RTBC
5 months ago 1:21pm 26 June 2024 - 🇮🇳India vipin.mittal18 Greater Noida
MR !30 makes this module D11 compatible.
- Status changed to Needs work
5 months ago 4:09pm 26 June 2024 - 🇺🇸United States japerry KVUO
I'd probably go back the original bot and re-run the scans. The merging of linting and deprecations makes it hard to understand what could be a breaking change downstream. It also removed Drupal 9.5 compatibility, which doesn't seem necessary.
3:53 55:51 Running1:48 55:51 Running59:18 52:51 Running- last update
5 months ago 5 pass, 4 fail - last update
5 months ago 9 pass - last update
5 months ago 9 pass - last update
5 months ago 9 pass - last update
5 months ago 9 pass - last update
5 months ago 9 pass - last update
5 months ago 9 pass - last update
5 months ago 9 pass - Status changed to RTBC
5 months ago 5:45am 27 June 2024 - 🇺🇸United States japerry KVUO
Tested both in gitlabci as well as locally on D9.5, 10, and 11.. all tests passing and is looking good to commit, pending one more minor change from ankitv18
- 🇮🇳India ankitv18
Juggling between the defined and version_compare to handle the BC for MASTER and MAIN request constant.
I'm going with the version_compare and defined will throw exception and also need additional check of version_compare to handle the proper BC.
So I believe version_compare is the good way to move forward. - Status changed to Needs review
5 months ago 11:02am 27 June 2024 - Status changed to RTBC
4 months ago 1:30pm 22 July 2024 - 🇮🇳India deepakkm
This is good to release, verified locally and its working fine.
- First commit to issue fork.
- 🇺🇸United States phenaproxima Massachusetts
Reviewed. I can see that 99% of the changes here are to comply with the coding standards. That leads to a lot of useless comments, but if it gets the pipelines passing, we can always improve those later. I think that concern is outweighed by the necessity of getting Subrequests released for Drupal 11, so I'm merging!
-
phenaproxima →
committed 18ec7d02 on 3.x authored by
ankitv18 →
Issue #3434821 by ankitv18, Rajeshreeputra, Project Update Bot, japerry...
-
phenaproxima →
committed 18ec7d02 on 3.x authored by
ankitv18 →
- Status changed to Fixed
3 months ago 1:56pm 6 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.