- Issue created by @project update bot
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module โ , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.
Therefore these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot โ to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-127659These packages were used to generate the fixes:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.9
- palantirnet/drupal-rector: 0.20.1
- Status changed to Closed: won't fix
9 months ago 4:50pm 16 May 2024 - ๐ญ๐บHungary Balu Ertl Budapest ๐ช๐บ
Balu Ertl โ made their first commit to this issueโs fork.
- Merge request !72Supply missing `TypedConfigManager` to parent constructor call โ (Closed) created by Balu Ertl
- Status changed to Needs review
8 months ago 4:19pm 15 June 2024 - ๐ญ๐บHungary Balu Ertl Budapest ๐ช๐บ
For better clarity why the changes suggested by the Upgrade Bot were not considered: for some reason, the MR was created against the non-default
2.1.x
branch. The file structure is different on the default3.0.x
branch and similar files already have the fixes the Bot suggested.However, I still felt the need to reopen this ticket, because (independently from the Bot's minor coding standard points) the 3.0.0-alpha1 โ version installed on a D11-beta1 site runs into an error when visiting its config page:
โArgumentCountError: Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct(), 1 passed in /var/www/html/web/modules/contrib/stage_file_proxy/src/Form/SettingsForm.php on line 26 and exactly 2 expected in Drupal\Core\Form\ConfigFormBase->__construct() (line 41 of core/lib/Drupal/Core/Form/ConfigFormBase.php).โ
As being relatively easy to fix in the form constructor, I opened a second MR on a different branch of this repo.
- Status changed to Needs work
8 months ago 4:50pm 18 June 2024 - ๐ฎ๐ณIndia samit.310@gmail.com
samit.310@gmail.com โ made their first commit to this issueโs fork.
- Merge request !73Resolve #3434751 "Automated drupal 11 fix" โ (Closed) created by samit.310@gmail.com
- ๐ฎ๐ณIndia samit.310@gmail.com
samit.310@gmail.com โ changed the visibility of the branch 3434751-automated-drupal-11 to hidden.
- ๐ฎ๐ณIndia samit.310@gmail.com
samit.310@gmail.com โ changed the visibility of the branch 3434751-automated-drupal-11 to active.
- ๐ฎ๐ณIndia samit.310@gmail.com
samit.310@gmail.com โ changed the visibility of the branch 3434751-automated-drupal-11 to hidden.
- Status changed to Needs review
8 months ago 7:35am 19 June 2024 - ๐บ๐ธUnited States smustgrave
Samit why did you open a new MR? Looks identical to the existing one
- ๐ฎ๐ณIndia samit.310@gmail.com
Hi @smustgrav,
actually the
3434751-automated-drupal-11
branch is not sync with 3.0.x, initially i used that branch and founds so much conflicts, so open a new MR for the sam.Thanks
Samit K. - ๐บ๐ธUnited States smustgrave
Should use the existing MR going to close this one
- ๐ฎ๐ณIndia samit.310@gmail.com
samit.310@gmail.com โ changed the visibility of the branch 3434751-automated-drupal-11 to active.
- ๐ฎ๐ณIndia samit.310@gmail.com
samit.310@gmail.com โ changed the visibility of the branch 3434751-automated-drupal-11-fix to hidden.
- ๐ฎ๐ณIndia samit.310@gmail.com
Hi @smustgrave,
I have changed it to existing MR, Please review.
https://git.drupalcode.org/project/stage_file_proxy/-/merge_requests/72
Thanks
Samit K. - Status changed to RTBC
8 months ago 11:06am 24 June 2024 - ๐ญ๐บHungary Balu Ertl Budapest ๐ช๐บ
Samit's latest commit was tested and found working on D11-beta1, setting to RTBC.
-
smustgrave โ
committed 1ada37bd on 3.0.x
Issue #3434751 by samit.310@gmail.com, Project Update Bot, Balu Ertl:...
-
smustgrave โ
committed 1ada37bd on 3.0.x
- Status changed to Fixed
8 months ago 2:38pm 27 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.