Contrib.social

Automated Drupal 11 compatibility fixes for simple_sitemap

Open on Drupal.org →
Created on 25 March 2024, 9 months ago
Updated 30 August 2024, 4 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Fixed

Version

4.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @project update bot
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 9 months ago
    PHPLint Failed
  • Comment 9 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

    Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

    Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

    The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-127659

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.9
    3. palantirnet/drupal-rector: 0.20.1
  • Merge request !90Automated Project Update Bot fixes → (Open) created by project update bot
  • Status changed to Needs review 9 months ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 9 months ago
    PHPLint Failed
  • Pipeline finished with Failed
    9 months ago
    Total: 3717s
    #128023
  • Pipeline finished with Failed
    9 months ago
    Total: 3720s
    #128024
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 7 months ago
    Not currently mergeable.
  • First commit to issue fork.
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 7 months ago
    32 pass
  • Pipeline finished with Failed
    7 months ago
    Total: 405s
    #172260
  • Pipeline finished with Success
    7 months ago
    Total: 339s
    #172268
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 7 months ago
    32 pass
  • Pipeline finished with Success
    7 months ago
    Total: 275s
    #172291
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 7 months ago
    32 pass
  • Comment 7 months ago →
    🇮🇳India ankitv18
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.x + Environment: php8.3_mysql8
    last update 7 months ago
    5 pass, 1 fail
  • Pipeline finished with Success
    7 months ago
    Total: 391s
    #172310
  • First commit to issue fork.
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 7 months ago
    32 pass
  • Pipeline finished with Success
    7 months ago
    Total: 338s
    #172341
  • Status changed to Needs work 7 months ago
  • Comment 7 months ago →
    🇮🇳India vishalkhode

    There are couple of PHPUnit tests are failing on Drupal 11 and this needs to be fixed

    1) Drupal\Tests\simple_sitemap_views\Functional\SimpleSitemapViewsTest::testSitemapSupportForViews
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for views.view.simple_sitemap_views_test_view with the following errors: views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.type.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.title.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.nid.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.page_2.display_options.arguments.type.default_argument_skip_url missing schema

/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:98
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:246
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:206
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:56
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Config.php:230
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:260
/Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php:486
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:239
/Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityBase.php:354
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php:610
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:389
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:149
/Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:75
/Users/user1/drupal11/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:322
/Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/Users/user1/drupal11/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:500
/Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:575
/Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
/Users/user1/drupal11/web/modules/contrib/simple_sitemap/tests/src/Functional/SimplesitemapTestBase.php:80
/Users/user1/drupal11/web/modules/contrib/simple_sitemap/modules/simple_sitemap_views/tests/src/Functional/SimpleSitemapViewsTestBase.php:62
/Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

2) Drupal\Tests\simple_sitemap_views\Functional\SimpleSitemapViewsTest::testIndexableViews
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for views.view.simple_sitemap_views_test_view with the following errors: views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.type.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.title.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.nid.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.page_2.display_options.arguments.type.default_argument_skip_url missing schema

/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:98
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:246
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:206
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:56
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Config.php:230
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:260
/Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php:486
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:239
/Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityBase.php:354
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php:610
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:389
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:149
/Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:75
/Users/user1/drupal11/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:322
/Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/Users/user1/drupal11/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:500
/Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:575
/Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
/Users/user1/drupal11/web/modules/contrib/simple_sitemap/tests/src/Functional/SimplesitemapTestBase.php:80
/Users/user1/drupal11/web/modules/contrib/simple_sitemap/modules/simple_sitemap_views/tests/src/Functional/SimpleSitemapViewsTestBase.php:62
/Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

3) Drupal\Tests\simple_sitemap_views\Functional\SimpleSitemapViewsTest::testAddArgumentsToIndex
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for views.view.simple_sitemap_views_test_view with the following errors: views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.type.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.title.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.nid.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.page_2.display_options.arguments.type.default_argument_skip_url missing schema

/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:98
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:246
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:206
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:56
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Config.php:230
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:260
/Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php:486
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:239
/Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityBase.php:354
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php:610
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:389
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:149
/Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:75
/Users/user1/drupal11/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:322
/Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/Users/user1/drupal11/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:500
/Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:575
/Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
/Users/user1/drupal11/web/modules/contrib/simple_sitemap/tests/src/Functional/SimplesitemapTestBase.php:80
/Users/user1/drupal11/web/modules/contrib/simple_sitemap/modules/simple_sitemap_views/tests/src/Functional/SimpleSitemapViewsTestBase.php:62
/Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

4) Drupal\Tests\simple_sitemap_views\Functional\SimpleSitemapViewsTest::testViewsUrlGenerator
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for views.view.simple_sitemap_views_test_view with the following errors: views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.type.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.title.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.nid.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.page_2.display_options.arguments.type.default_argument_skip_url missing schema

/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:98
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:246
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:206
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:56
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Config.php:230
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:260
/Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php:486
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:239
/Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityBase.php:354
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php:610
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:389
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:149
/Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:75
/Users/user1/drupal11/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:322
/Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/Users/user1/drupal11/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:500
/Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:575
/Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
/Users/user1/drupal11/web/modules/contrib/simple_sitemap/tests/src/Functional/SimplesitemapTestBase.php:80
/Users/user1/drupal11/web/modules/contrib/simple_sitemap/modules/simple_sitemap_views/tests/src/Functional/SimpleSitemapViewsTestBase.php:62
/Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

5) Drupal\Tests\simple_sitemap_views\Functional\SimpleSitemapViewsTest::testGarbageCollector
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for views.view.simple_sitemap_views_test_view with the following errors: views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.type.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.title.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.nid.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.page_2.display_options.arguments.type.default_argument_skip_url missing schema

/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:98
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:246
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:206
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:56
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Config.php:230
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:260
/Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php:486
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:239
/Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityBase.php:354
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php:610
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:389
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:149
/Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:75
/Users/user1/drupal11/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:322
/Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/Users/user1/drupal11/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:500
/Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:575
/Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
/Users/user1/drupal11/web/modules/contrib/simple_sitemap/tests/src/Functional/SimplesitemapTestBase.php:80
/Users/user1/drupal11/web/modules/contrib/simple_sitemap/modules/simple_sitemap_views/tests/src/Functional/SimpleSitemapViewsTestBase.php:62
/Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

6) Drupal\Tests\simple_sitemap\Functional\SimplesitemapTest::testAddCustomLink
Behat\Mink\Exception\ResponseTextException: The text "/node/1 0.2 monthly" was not found anywhere in the text of the current page.

/Users/user1/drupal11/vendor/behat/mink/src/WebAssert.php:907
/Users/user1/drupal11/vendor/behat/mink/src/WebAssert.php:293
/Users/user1/drupal11/web/core/tests/Drupal/Tests/WebAssert.php:975
/Users/user1/drupal11/web/modules/contrib/simple_sitemap/tests/src/Functional/SimplesitemapTest.php:127
/Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

7) Drupal\Tests\simple_sitemap\Functional\SimplesitemapTest::testLocking
Behat\Mink\Exception\ElementNotFoundException: Button with id|name|label|value "Save configuration" not found.

/Users/user1/drupal11/web/core/tests/Drupal/Tests/WebAssert.php:158
/Users/user1/drupal11/web/core/tests/Drupal/Tests/UiHelperTrait.php:78
/Users/user1/drupal11/web/modules/contrib/simple_sitemap/tests/src/Functional/SimplesitemapTest.php:170
/Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

8) Drupal\Tests\simple_sitemap\Functional\SimplesitemapTest::testLinkCount
Undefined array key 0

/Users/user1/drupal11/web/modules/contrib/simple_sitemap/tests/src/Functional/SimplesitemapTest.php:321
/Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

--

There was 1 risky test:

1) Drupal\Tests\simple_sitemap_views\Functional\SimpleSitemapViewsTest::testSitemapSupportForViews
This test did not perform any assertions

/Users/user1/drupal11/web/core/tests/Drupal/Tests/Listeners/DrupalListener.php:61
/Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestResult.php:453
/Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestSuite.php:685
/Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestSuite.php:685
/Users/user1/drupal11/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:651
/Users/user1/drupal11/vendor/phpunit/phpunit/src/TextUI/Command.php:146
/Users/user1/drupal11/vendor/phpunit/phpunit/src/TextUI/Command.php:99
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 7 months ago
    32 pass
  • Pipeline finished with Success
    7 months ago
    Total: 346s
    #175124
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 7 months ago
    32 pass
  • Pipeline finished with Success
    7 months ago
    Total: 381s
    #176842
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 7 months ago
    5 pass, 2 fail
  • Pipeline finished with Failed
    7 months ago
    #176856
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 7 months ago
    32 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 7 months ago
    32 pass
  • Pipeline finished with Canceled
    7 months ago
    Total: 465s
    #176864
  • Pipeline finished with Success
    7 months ago
    #176868
  • Status changed to Needs review 7 months ago
  • Comment 7 months ago →
    🇮🇳India rajeshreeputra Pune

    For phpcs issue/warnings fixes please see 📌 Fix phpcs issue/warnings. Needs work .

  • Status changed to Needs work 7 months ago
  • Comment 7 months ago →
    🇷🇺Russia walkingdexter

    I'm not sure about these changes:

    They need to be carefully reviewed. At least there is no need to change the file mode. Additionally, any errors from the validate step should be fixed.

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 7 months ago
    32 pass
  • Pipeline finished with Failed
    7 months ago
    Total: 347s
    #177982
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 7 months ago
    32 pass
  • Pipeline finished with Failed
    7 months ago
    Total: 334s
    #178025
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 7 months ago
    32 pass
  • Pipeline finished with Success
    7 months ago
    Total: 287s
    #178075
  • Comment 7 months ago →
    🇮🇳India rajeshreeputra Pune

    Additionally, any errors from the validate step should be fixed.

    • PHPCS: Fixed warnings.
    • Eslint: We will retain this for the maintainer to take appropriate action.
    • PHPStan: Already appended the 'ignore next line' directive, but it appears to be non-functional.
  • Status changed to Needs review 7 months ago
  • Comment 7 months ago →
    🇮🇳India rajeshreeputra Pune
  • Status changed to RTBC 7 months ago
  • Comment 7 months ago →
    🇮🇳India vishalkhode

    @Rajeshreeputra Reviewed MR and changes looks good to me.

    @WalkingDexter: If your plan is to make a new major release support starting from Drupal Core 10.1.x or If plan is to make a patch release for the same reason, then we can merge the changes. If not, then we need to add the DeprecationHelper class in the module itself, so that it works on Drupal Core 9.3.x as well.

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 7 months ago
    32 pass
  • Pipeline finished with Success
    7 months ago
    Total: 348s
    #178576
  • Status changed to Needs review 7 months ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 7 months ago
    32 pass
  • Comment 7 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

    Currently Drupal Rector, version 0.20.2, cannot fix all Drupal 11 compatibility problems.

    Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

    The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-188815

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.2
    2. mglaman/phpstan-drupal: 1.2.11
    3. palantirnet/drupal-rector: 0.20.2
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 7 months ago
    32 pass
  • Pipeline finished with Success
    7 months ago
    Total: 394s
    #189222
  • Merge request !98Resolve #3434566 "Automated drupal 11" → (Closed) created by rajeshreeputra
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 6 months ago
    32 pass
  • Comment 6 months ago →
    🇮🇳India rajeshreeputra Pune

    Rajeshreeputra → changed the visibility of the branch project-update-bot-only to hidden.

  • Pipeline finished with Success
    6 months ago
    Total: 308s
    #196845
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 6 months ago
    32 pass
  • Pipeline finished with Success
    6 months ago
    Total: 305s
    #196854
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    14:03
    14:03
    Queueing
  • Comment 6 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

    Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.

    Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

    The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-199781

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.2
    2. mglaman/phpstan-drupal: 1.2.11
    3. palantirnet/drupal-rector: 0.20.3
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    13:48
    13:48
    Queueing
  • Pipeline finished with Success
    6 months ago
    Total: 320s
    #201605
  • Status changed to Needs work 6 months ago
  • Comment 6 months ago →
    🇷🇺Russia walkingdexter

    I still see a lot of unnecessary changes that are not related to the issue. Please explain why these changes are needed. In my opinion, the only changes we need here are the changes that Project-Update-Bot suggests. Also we cannot rely on DeprecationHelper as it's available since version 10.1.3 (see the change record → ). We must either drop support for Drupal 9 or implement a workaround.

  • Comment 6 months ago →
    🇮🇳India rajeshreeputra Pune

    I concur with your assessment, @WalkingDexter, that support for D9 and D10.1 can be discontinued. Additionally, the changes related to PHPSC can be effectively addressed within the scope of a separate ticket. Will create separate ticket for the same and segregate the changes accordingly.

  • Assigned to rajeshreeputra
  • Comment 6 months ago →
    🇮🇳India rajeshreeputra Pune
  • Merge request !99Issue#3434566: D11 readiness. → (Closed) created by ankitv18
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 6 months ago
    32 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 6 months ago
    32 pass
  • Pipeline finished with Failed
    6 months ago
    #205428
  • Pipeline finished with Failed
    6 months ago
    Total: 322s
    #205430
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 6 months ago
    32 pass
  • Pipeline finished with Success
    6 months ago
    Total: 315s
    #205439
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 6 months ago
    32 pass
  • Pipeline finished with Success
    6 months ago
    Total: 382s
    #205445
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 6 months ago
    32 pass
  • Pipeline finished with Success
    6 months ago
    Total: 306s
    #205451
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 6 months ago
    4 fail
  • Pipeline finished with Failed
    6 months ago
    Total: 285s
    #205458
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 6 months ago
    32 pass
  • Pipeline finished with Failed
    6 months ago
    Total: 756s
    #205462
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 6 months ago
    32 pass
  • Pipeline finished with Success
    6 months ago
    Total: 483s
    #205471
  • Comment 6 months ago →
    🇮🇳India ankitv18

    ankitv18 → changed the visibility of the branch 3434566-automated-drupal-11 to hidden.

  • Issue was unassigned.
  • Status changed to Needs review 6 months ago
  • Comment 6 months ago →
    🇮🇳India ankitv18

    Please review MR!99

  • Comment 5 months ago →
    🇷🇺Russia walkingdexter

    WalkingDexter → changed the visibility of the branch project-update-bot-only to active.

  • Merge request !101Issue #3434566: Automated Drupal 11 compatibility fixes for simple_sitemap → (Merged) created by walkingdexter
  • Comment 5 months ago →
    🇷🇺Russia walkingdexter

    WalkingDexter → changed the visibility of the branch 3434566-d11-ready to hidden.

  • Comment 5 months ago →
    System Message
  • Comment 5 months ago →
    System Message
  • Comment 5 months ago →
    System Message
  • Status changed to Active 5 months ago
  • Comment 5 months ago →
    🇷🇺Russia walkingdexter

    Merged with changes and additions, thanks! Also dropped support for Drupal 9. All credits saved.

  • Status changed to Fixed 5 months ago
  • Comment 5 months ago →
    🇷🇺Russia walkingdexter
  • Comment 5 months ago →
    🇮🇳India vipin.mittal18 Greater Noida

    Hello @WalkingDexter,

    We are approaching the release of Drupal 11, so should we expect stable version for this module before that release? Thanks!

  • Comment 4 months ago →
    🇷🇺Russia walkingdexter

    We are approaching the release of Drupal 11, so should we expect stable version for this module before that release?

    I don't have permission to create new releases. Only @gbyte can do this.

  • Comment 4 months ago →
    🇬🇧United Kingdom darren.fisher

    +1 for full release! Appreciate all of your hard work on this. All of our sites use this module and we're currently auditing D11 compatibility and this module is a blocker across all of our sites.

  • Comment 4 months ago →
    🇩🇪Germany gbyte Berlin

    @vipin.mittal18, darren.fisher

    I hear you. Let's create the release as soon as we sort out 🌱 About semantic versioning Active .

  • Comment 4 months ago →
    🇩🇪Germany gbyte Berlin

    I hear you. Let's create the release as soon as we sort out #3399117: About semantic versioning.

    Done → .

  • Comment 4 months ago →
    🇬🇧United Kingdom darren.fisher

    Thank you so much!! This is awesome news!

  • Comment 4 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024