- Issue created by @Project Update Bot
- last update
3 months ago PHPLint Failed This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.
Therefore these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-127659These packages were used to generate the fixes:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.9
- palantirnet/drupal-rector: 0.20.1
- Status changed to Needs review
3 months ago 12:34am 25 March 2024 - last update
3 months ago PHPLint Failed - Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MySQL 8last update
about 1 month ago Not currently mergeable. - First commit to issue fork.
- last update
about 1 month ago 32 pass - last update
about 1 month ago 32 pass - last update
about 1 month ago 32 pass - last update
about 1 month ago 5 pass, 1 fail - First commit to issue fork.
- last update
about 1 month ago 32 pass - Status changed to Needs work
about 1 month ago 4:40am 16 May 2024 - 🇮🇳India vishalkhode
There are couple of PHPUnit tests are failing on Drupal 11 and this needs to be fixed
1) Drupal\Tests\simple_sitemap_views\Functional\SimpleSitemapViewsTest::testSitemapSupportForViews Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for views.view.simple_sitemap_views_test_view with the following errors: views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.type.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.title.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.nid.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.page_2.display_options.arguments.type.default_argument_skip_url missing schema /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:98 /Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:246 /Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:206 /Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:56 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Config.php:230 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:260 /Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php:486 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:239 /Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityBase.php:354 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php:610 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:389 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:149 /Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:75 /Users/user1/drupal11/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:322 /Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83 /Users/user1/drupal11/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:500 /Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:575 /Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:370 /Users/user1/drupal11/web/modules/contrib/simple_sitemap/tests/src/Functional/SimplesitemapTestBase.php:80 /Users/user1/drupal11/web/modules/contrib/simple_sitemap/modules/simple_sitemap_views/tests/src/Functional/SimpleSitemapViewsTestBase.php:62 /Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestResult.php:729 2) Drupal\Tests\simple_sitemap_views\Functional\SimpleSitemapViewsTest::testIndexableViews Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for views.view.simple_sitemap_views_test_view with the following errors: views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.type.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.title.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.nid.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.page_2.display_options.arguments.type.default_argument_skip_url missing schema /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:98 /Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:246 /Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:206 /Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:56 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Config.php:230 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:260 /Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php:486 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:239 /Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityBase.php:354 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php:610 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:389 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:149 /Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:75 /Users/user1/drupal11/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:322 /Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83 /Users/user1/drupal11/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:500 /Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:575 /Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:370 /Users/user1/drupal11/web/modules/contrib/simple_sitemap/tests/src/Functional/SimplesitemapTestBase.php:80 /Users/user1/drupal11/web/modules/contrib/simple_sitemap/modules/simple_sitemap_views/tests/src/Functional/SimpleSitemapViewsTestBase.php:62 /Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestResult.php:729 3) Drupal\Tests\simple_sitemap_views\Functional\SimpleSitemapViewsTest::testAddArgumentsToIndex Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for views.view.simple_sitemap_views_test_view with the following errors: views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.type.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.title.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.nid.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.page_2.display_options.arguments.type.default_argument_skip_url missing schema /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:98 /Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:246 /Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:206 /Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:56 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Config.php:230 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:260 /Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php:486 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:239 /Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityBase.php:354 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php:610 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:389 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:149 /Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:75 /Users/user1/drupal11/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:322 /Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83 /Users/user1/drupal11/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:500 /Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:575 /Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:370 /Users/user1/drupal11/web/modules/contrib/simple_sitemap/tests/src/Functional/SimplesitemapTestBase.php:80 /Users/user1/drupal11/web/modules/contrib/simple_sitemap/modules/simple_sitemap_views/tests/src/Functional/SimpleSitemapViewsTestBase.php:62 /Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestResult.php:729 4) Drupal\Tests\simple_sitemap_views\Functional\SimpleSitemapViewsTest::testViewsUrlGenerator Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for views.view.simple_sitemap_views_test_view with the following errors: views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.type.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.title.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.nid.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.page_2.display_options.arguments.type.default_argument_skip_url missing schema /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:98 /Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:246 /Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:206 /Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:56 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Config.php:230 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:260 /Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php:486 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:239 /Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityBase.php:354 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php:610 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:389 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:149 /Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:75 /Users/user1/drupal11/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:322 /Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83 /Users/user1/drupal11/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:500 /Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:575 /Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:370 /Users/user1/drupal11/web/modules/contrib/simple_sitemap/tests/src/Functional/SimplesitemapTestBase.php:80 /Users/user1/drupal11/web/modules/contrib/simple_sitemap/modules/simple_sitemap_views/tests/src/Functional/SimpleSitemapViewsTestBase.php:62 /Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestResult.php:729 5) Drupal\Tests\simple_sitemap_views\Functional\SimpleSitemapViewsTest::testGarbageCollector Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for views.view.simple_sitemap_views_test_view with the following errors: views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.type.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.title.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.nid.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.page_2.display_options.arguments.type.default_argument_skip_url missing schema /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:98 /Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:246 /Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:206 /Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:56 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Config.php:230 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:260 /Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php:486 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:239 /Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityBase.php:354 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php:610 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:389 /Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:149 /Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:75 /Users/user1/drupal11/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:322 /Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83 /Users/user1/drupal11/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:500 /Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:575 /Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:370 /Users/user1/drupal11/web/modules/contrib/simple_sitemap/tests/src/Functional/SimplesitemapTestBase.php:80 /Users/user1/drupal11/web/modules/contrib/simple_sitemap/modules/simple_sitemap_views/tests/src/Functional/SimpleSitemapViewsTestBase.php:62 /Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestResult.php:729 6) Drupal\Tests\simple_sitemap\Functional\SimplesitemapTest::testAddCustomLink Behat\Mink\Exception\ResponseTextException: The text "/node/1 0.2 monthly" was not found anywhere in the text of the current page. /Users/user1/drupal11/vendor/behat/mink/src/WebAssert.php:907 /Users/user1/drupal11/vendor/behat/mink/src/WebAssert.php:293 /Users/user1/drupal11/web/core/tests/Drupal/Tests/WebAssert.php:975 /Users/user1/drupal11/web/modules/contrib/simple_sitemap/tests/src/Functional/SimplesitemapTest.php:127 /Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestResult.php:729 7) Drupal\Tests\simple_sitemap\Functional\SimplesitemapTest::testLocking Behat\Mink\Exception\ElementNotFoundException: Button with id|name|label|value "Save configuration" not found. /Users/user1/drupal11/web/core/tests/Drupal/Tests/WebAssert.php:158 /Users/user1/drupal11/web/core/tests/Drupal/Tests/UiHelperTrait.php:78 /Users/user1/drupal11/web/modules/contrib/simple_sitemap/tests/src/Functional/SimplesitemapTest.php:170 /Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestResult.php:729 8) Drupal\Tests\simple_sitemap\Functional\SimplesitemapTest::testLinkCount Undefined array key 0 /Users/user1/drupal11/web/modules/contrib/simple_sitemap/tests/src/Functional/SimplesitemapTest.php:321 /Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestResult.php:729 -- There was 1 risky test: 1) Drupal\Tests\simple_sitemap_views\Functional\SimpleSitemapViewsTest::testSitemapSupportForViews This test did not perform any assertions /Users/user1/drupal11/web/core/tests/Drupal/Tests/Listeners/DrupalListener.php:61 /Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestResult.php:453 /Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestSuite.php:685 /Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestSuite.php:685 /Users/user1/drupal11/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:651 /Users/user1/drupal11/vendor/phpunit/phpunit/src/TextUI/Command.php:146 /Users/user1/drupal11/vendor/phpunit/phpunit/src/TextUI/Command.php:99
- last update
about 1 month ago 32 pass - last update
29 days ago 32 pass - last update
29 days ago 5 pass, 2 fail - last update
29 days ago 32 pass - last update
29 days ago 32 pass - Status changed to Needs review
29 days ago 7:39am 20 May 2024 - 🇮🇳India Rajeshreeputra Pune
For phpcs issue/warnings fixes please see 📌 Fix phpcs issue/warnings. Needs work .
- Status changed to Needs work
29 days ago 4:02pm 20 May 2024 - 🇷🇺Russia WalkingDexter
I'm not sure about these changes:
- https://git.drupalcode.org/project/simple_sitemap/-/merge_requests/90/di...
- https://git.drupalcode.org/project/simple_sitemap/-/merge_requests/90/di...
They need to be carefully reviewed. At least there is no need to change the file mode. Additionally, any errors from the validate step should be fixed.
- last update
28 days ago 32 pass - last update
28 days ago 32 pass - last update
28 days ago 32 pass - 🇮🇳India Rajeshreeputra Pune
Additionally, any errors from the validate step should be fixed.
- PHPCS: Fixed warnings.
- Eslint: We will retain this for the maintainer to take appropriate action.
- PHPStan: Already appended the 'ignore next line' directive, but it appears to be non-functional.
- Status changed to Needs review
28 days ago 1:21pm 21 May 2024 - Status changed to RTBC
28 days ago 6:37pm 21 May 2024 - 🇮🇳India vishalkhode
@Rajeshreeputra Reviewed MR and changes looks good to me.
@WalkingDexter: If your plan is to make a new major release support starting from Drupal Core 10.1.x or If plan is to make a patch release for the same reason, then we can merge the changes. If not, then we need to add the
DeprecationHelper
class in the module itself, so that it works on Drupal Core 9.3.x as well. - last update
28 days ago 32 pass - Status changed to Needs review
16 days ago 5:58pm 2 June 2024 - last update
16 days ago 32 pass This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.2, cannot fix all Drupal 11 compatibility problems.
Therefore, these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-188815These packages were used to generate the fixes:
- drupal/upgrade_status: 4.3.2
- mglaman/phpstan-drupal: 1.2.11
- palantirnet/drupal-rector: 0.20.2
- last update
16 days ago 32 pass - last update
6 days ago 32 pass - 🇮🇳India Rajeshreeputra Pune
Rajeshreeputra → changed the visibility of the branch project-update-bot-only to hidden.
- last update
6 days ago 32 pass - Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
48:32 48:32 Queueing This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.
Therefore, these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-199781These packages were used to generate the fixes:
- drupal/upgrade_status: 4.3.2
- mglaman/phpstan-drupal: 1.2.11
- palantirnet/drupal-rector: 0.20.3
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
48:17 48:17 Queueing