Automated Drupal 11 compatibility fixes for seckit

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.9
3. palantirnet/drupal-rector: 0.20.1

Running command ./vendor/bin/drush upgrade_status:analyze seckit I can see following issues:

================================================================================
Security Kit, --
Scanned on Tue, 05/14/2024 - 11:44

FILE: modules/contrib/seckit/tests/src/Functional/SecKitTestCaseTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 66   Call to deprecated method getConfig() of interface          
                    GuzzleHttp\ClientInterface: ClientInterface::getConfig will 
                    be removed in guzzlehttp/guzzle:8.0.                        
--------------------------------------------------------------------------------

FILE: modules/contrib/seckit/seckit.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 4    Value of core_version_requirement: ^9.3 || ^10 is not       
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

chandu7929 → changed the visibility of the branch project-update-bot-only to hidden.

chandu7929 → changed the visibility of the branch project-update-bot-only to active.

chandu7929 → changed the visibility of the branch 3434417-automated-drupal-11 to hidden.

vishalkhode → changed the visibility of the branch project-update-bot-only to hidden.

I've fixed all the deprecated warnings and verified PHPUnit tests are also passing in Drupal 11. Please review MR.

After apply the MR!26 there are no more issues when I run upgrade status, please check the screenshot ~~ marking this RTBC

Any chance for merge?

@jweowu - Can you please review merge and release this?

This will break below D10.2 due to typedConfigManager.

Pushed the change please review the MR now.

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.4
2. mglaman/phpstan-drupal: 1.2.11
3. palantirnet/drupal-rector: 0.20.3

MR !26 changes are compatible for D11

MR is currently failing tests AFAICS.

Hello Drew, fixes has already been done at https://git.drupalcode.org/project/seckit/-/merge_requests/27/diffs and @chandan has already merged in this PR. It would be good if we merge GitLab CI too. Thanks!

Added a gitlab-ci template.

MR26 is failing most if not all of the tests like this:

29) Drupal\Tests\seckit\Functional\SecKitTestCaseTest::testEnabledReferrerPolicy
Behat\Mink\Exception\ElementNotFoundException: Button with id|name|label|value "Save configuration" not found.

/var/www/html/core/tests/Drupal/Tests/WebAssert.php:158
/var/www/html/core/tests/Drupal/Tests/UiHelperTrait.php:78
/var/www/html/modules/contrib/seckit/tests/src/Functional/SecKitTestCaseTest.php:630

-----

To make this easier to review, can we have some comments / references about where things like the "Handling the BC for typedConfigManager." commit comes from?

Is the solution of removing the constructor completely and calling the parent from the create method a novel solution or is it following a pattern documented elsewhere?

Does this ensure that the deprecation is solved for D11 but the module still works / passes tests for D10.2/10.3?

In order to review these commits properly, I'm having to do quite a bit of digging and research.

It'd be a lot easier if you could give me some clues as to what I'm looking at, and why certain changes are being made. Thanks!

@mcdruid Sorry that was miss from my end, By mistake I’ve reversed the containerisation for respective properties.
I've executed the pipelines and all jobs are passing now.

By the way typedConfigManager passed as an argument from D10.2 in configFormBase class and settingsForm.php consists of config.factory and typed.config which is already passed as an argument in https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Form%21Co...

So as parent class already having those argument so I don’t see any objective of overriding the parent properties and creating the instance with the same properties.

Suggestion I either go with this changes or support minimum D10.2 then we can add back constructor with both configFactory and typedConfigManager as an argument required by configFormBase class.

Okay, thanks for the explanations and fixes.

Here's the CR about the typedConfigManager / ConfigFormBase deprecation:

https://www.drupal.org/node/3404140 →

At some point we should update the constraints to remove D9, but perhaps that should be 2.1.x

Let's get this merged and then we can look at the other test / static checks fixes in 📌 Fix validate pipeline Fixed (thanks for working on that too!)

Thanks everyone that contributed.

There's follow-up before tagging new release 📌 Automated Drupal 11 compatibility fixes for seckit Needs review

Automatically closed - issue fixed for 2 weeks with no activity.