Contrib.social

Automated Drupal 11 compatibility fixes for path_redirect_import

Open on Drupal.org →
Created on 24 March 2024, about 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Needs review

Version

2.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @project update bot
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7
    last update about 1 year ago
    3 pass
  • Comment about 1 year ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-127659

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.9
    3. palantirnet/drupal-rector: 0.20.1
  • Merge request !27Automated Project Update Bot fixes → (Open) created by project update bot
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7
    last update about 1 year ago
    3 pass
  • Pipeline finished with Success
    about 1 year ago
    Total: 143s
    #127855
  • Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7
    27:58
    27:58
    Queueing
  • Comment 11 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-199781

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.2
    2. mglaman/phpstan-drupal: 1.2.11
    3. palantirnet/drupal-rector: 0.20.3
  • Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7
    27:45
    27:45
    Queueing
  • Pipeline finished with Success
    11 months ago
    Total: 138s
    #201557
  • Comment 8 months ago →
    🇬🇧United Kingdom darren.fisher

    Is there a timeline for getting this merged? Drupal 11 is out now and we're auditing our readiness to upgrade and have a lot of websites using this module. Many thanks!

  • Comment 8 months ago →
    🇺🇸United States emptyvoid

    Upgrade Status Code Audit Report:
    ================================================================================

    ================================================================================
Path Redirect Import,  2.0.9
Scanned on Fri, 09/13/2024 - 11:59

FILE:
modules/contrib/path_redirect_import/src/Drush/Commands/PathRedirectImportComman
ds.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Ignore         106  Fetching deprecated class constant EXISTS_REPLACE of        
                    interface Drupal\Core\File\FileSystemInterface. Deprecated  
                    in drupal:10.3.0 and is removed from drupal:12.0.0. Use     
                    Drupal\Core\File\FileExists::Replace instead.               
--------------------------------------------------------------------------------

FILE: modules/contrib/path_redirect_import/src/Form/MigrateRedirectForm.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Ignore         287  Fetching deprecated class constant EXISTS_REPLACE of        
                    interface Drupal\Core\File\FileSystemInterface. Deprecated  
                    in drupal:10.3.0 and is removed from drupal:12.0.0. Use     
                    Drupal\Core\File\FileExists::Replace instead.               
--------------------------------------------------------------------------------

FILE: modules/contrib/path_redirect_import/src/RedirectExport.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Ignore         89   Fetching deprecated class constant EXISTS_REPLACE of        
                    interface Drupal\Core\File\FileSystemInterface. Deprecated  
                    in drupal:10.3.0 and is removed from drupal:12.0.0. Use     
                    Drupal\Core\File\FileExists::Replace instead.               
--------------------------------------------------------------------------------


FILE: modules/contrib/path_redirect_import/path_redirect_import.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 4    Value of core_version_requirement: ^9.3||^10 is not         
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------
  • Comment 8 months ago →
    🇺🇸United States emptyvoid

    uploaded file attempting to "fix" noted issues and creating a patch.

  • First commit to issue fork.
  • Comment 7 months ago →
    🇺🇦Ukraine olmyr Ukraine, Kharkiv

    olmyr → changed the visibility of the branch 3433869-automated-drupal-11 to hidden.

  • Comment 7 months ago →
    🇺🇦Ukraine olmyr Ukraine, Kharkiv

    olmyr → changed the visibility of the branch project-update-bot-only to hidden.

  • Merge request !31Issue #3433869 by olmyr: Automated Drupal 11 compatibility fixes for path_redirect_import → (Merged) created by olmyr
  • Pipeline finished with Failed
    7 months ago
    Total: 173s
    #302118
  • Pipeline finished with Failed
    7 months ago
    Total: 297s
    #302123
  • Pipeline finished with Failed
    7 months ago
    Total: 220s
    #302128
  • Pipeline finished with Failed
    7 months ago
    Total: 141s
    #302129
  • Pipeline finished with Failed
    7 months ago
    Total: 363s
    #302131
  • Pipeline finished with Success
    7 months ago
    Total: 136s
    #302157
  • Pipeline finished with Success
    7 months ago
    Total: 1165s
    #302167
  • Comment 6 months ago →
    🇺🇦Ukraine podarok Ukraine
  • Status changed to Needs work 4 months ago
  • Comment 4 months ago →
    🇫🇷France Fabsgugu
  • Comment 3 months ago →
    🇫🇷France Fabsgugu
  • Pipeline finished with Success
    3 months ago
    Total: 184s
    #411310
  • Comment 3 months ago →
    🇺🇸United States thejimbirch Cape Cod, Massachusetts

    Tests pass on MR 31. Updates made by @Fabsgugu no longer give an error.

    Marking as RTBC. Thanks so much!

  • First commit to issue fork.
  • Comment 3 months ago →
    🇪🇸Spain plopesc Valladolid

    Drop 9.x support since new changes breaks compatibility with that core version.

    Preparing a new 2.1.0 module release fro 10.3+.

  • Pipeline finished with Skipped
    3 months ago
    #414430
  • Comment 3 months ago →
    System Message
  • Comment 3 months ago →
    🇪🇸Spain plopesc Valladolid

    MR has been merged and 2.1.0 released.

    Thank you all for your help here!

  • Comment 3 months ago →
    🇨🇭Switzerland ayalon

    Awesome! Thank you!

  • Comment 2 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024