Automated Drupal 11 compatibility fixes for paragraphs

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.9
3. palantirnet/drupal-rector: 0.20.1

I've added a repository to an MR for the entity_reference_revisions module so that test for Drupal 11 can be performed.

ERR D11 support is merged, updated composer.json and made all other dependencies lenient, composer build completes now on next majors but tests die hard due to the https://git.drupalcode.org/project/paragraphs/-/jobs/1683168 EntityReferenceTestTrait. That means we won't be able to test on 10.1 or lower, so previous minor will break and will have to be removed I guess.

One of the kernel migration tests is causing an infinite recursion in discovery of migration plugins. No idea about this code...

See https://git.drupalcode.org/project/paragraphs/-/merge_requests/102/diffs... and the referenced gist for the backtrace.

This is complex enough without phpcs/style changes. That's no in way related to Drupal 11 compatibility.

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.2, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.2
2. mglaman/phpstan-drupal: 1.2.11
3. palantirnet/drupal-rector: 0.20.2

Looks like the bot broke the issue fork badly.

All commits after 25.5.2020 (i.e. 4 years ago) are suddenly gone in the project-update-bot-only branch.

we shouldn't have worked on that anyway, it did warn us, I'll reupload a local one, but there might also be a tagged backup.

(I would expect it would have just deleted our changes, not use a 4 year old one, but I guess it wanted to make a point or something ;))

but I guess it wanted to make a point or something

That rather feels like a serious bug, especially since the bot also created a second MR on the same source and target combination. I didn't think that would even be possible with git.

Anyways, should we recover this by creating a second issue fork and re-build the changes that got lost? I'm asking because that would allow us to use that fork as a dependency for some scheduled Drupal 11 pipelines.

That was just a joke, I do hope the update bot is not sentient enough to punish us ;)

but yes, we should push the changes to a separate branch (in the same fork) maybe the one that got created by default already, and continue there. not expecting much more from the bot here anyway.

also, I had already extracted all the changes to fix 10.2/10.3 tests into 📌 Drupal 10.2/10.3 test fixes Fixed , the blocker now is that migration stuff, that sounds like it might require a major rewrite.

Honestly tempted to just rip that all out and push it in a separate contrib project and let someone else maintain it.

OK, I've started the branch 3433816-manual-drupal-11 and created MR!114 as a starting point which contains the 2 proposed patches from the bot and declares Drupal 11 compatibility in the info file.

Berdir → closed merge request !114

Berdir → closed merge request !102

Berdir → closed merge request !113

Berdir → changed the visibility of the branch 3433816-manual-drupal-11 to hidden.

I recovered my local old branch with all the work that was done here, rebased on 8.x-1.x, pushed to https://git.drupalcode.org/project/paragraphs/-/merge_requests/115. Closed all other merge requests.

Thanks @Berdir let's hope that the bot doesn't override that branch next time it runs.

This isn't the same branch than the bot used, that one is named "project-update-bot-only", the one that has automated in the name is just named because it's the default branch created by drupal.org for the issue fork based on the issue title name. That one should not get overwritten.

Not sure, we're on safe ground here. As you can see from https://www.drupal.org/project/paragraphs/issues/3433816#mr113-note320523 📌 Automated Drupal 11 compatibility fixes for paragraphs Needs review and https://www.drupal.org/project/paragraphs/issues/3433816#mr102-note320522 📌 Automated Drupal 11 compatibility fixes for paragraphs Needs review the bot committed to both open MRs back when it screwed up.

@jurgenhaas: Both merge requests yes, but if you click on them or check the hidden branches on the issue summary you can see that both branches were opened for the same branch, project-update-bot-only. There's no guarantee with how bad the bot got confused here, but IMHO, using 3433816-automated-drupal-11 is as safe as any other branch on this fork.

As per slack conversation with Berdir. Will hide the files for the bot so we can test updated logic to find the correct branch.

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.2, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.2
2. mglaman/phpstan-drupal: 1.2.11
3. palantirnet/drupal-rector: 0.20.2

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.2
2. mglaman/phpstan-drupal: 1.2.11
3. palantirnet/drupal-rector: 0.20.3

This now requires 10.2 and I removed a lot of BC layers, mostly in tests. The migrate workarounds are ugly, but I don't see another option without a major time investment. The migrate integration will most likely be removed if/when there is a 2.x of paragraphs.

The only failing tests are the IEF integration tests and I verified that they pass locally with the WIP patch from the IEF issue.

Merged.

2 tests still fails in CI

Automatically closed - issue fixed for 2 weeks with no activity.