Automated Drupal 11 compatibility fixes for media_acquiadam

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug info

This patch was created using these packages:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.7
3. palantirnet/drupal-rector: 0.20.1

This comment was forced and has ignored the check if a change was already posted. This is only done when we want to update the issue without waiting for changes to happen.

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.10
3. palantirnet/drupal-rector: 0.20.1

Balu Ertl → made their first commit to this issue’s fork.

Balu Ertl → changed the visibility of the branch project-update-bot-only to hidden.

Reviewed, tested on a D11-alpha1 site, missing fixes manually added.

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.2
2. mglaman/phpstan-drupal: 1.2.11
3. palantirnet/drupal-rector: 0.20.3

gitlab.ci needs to be added and tests passing before we merge this.

A customized version of DA's .gitlab-ci.yml template has been added to the project, but the first pipeline instantly broke with an error about something called “cghooks”:

[…]
> vendor/bin/cghooks update
527sh: 1: vendor/bin/cghooks: not found
528Script vendor/bin/cghooks update handling the post-update-cmd event returned with error code 127

If it refers to the BrainMaestro/composer-git-hooks package then I'm unsure how it is expected to do its job as not being required directly by this module.

A possibly conflicting situation emerges: meanwhile an ORCA-based .gitlab-ci.yml file is also being added to the project in 📌 Onboard to Gitlab CI Active .

Decision needs to be made which one do we want to include for this project.

A possibly conflicting situation emerges: meanwhile an ORCA-based .gitlab-ci.yml file is also being added to the project in 📌 Onboard to Gitlab CI Active . A decision needs to be made which one do we want to include for this project.

Also, the following tickets are still open which logically blocks focusing on D11 compatibility:

1. 📌 Automated Drupal 10 compatibility fixes Needs review
2. ✨ Upgrade acquia-dam-1x to work with D10 Needs work
3. 📌 Automated Drupal 10 compatibility fixes Needs review

Personally, I would suggest to revisit them first, clean up the situation around them, and once it's confirmed that a stable release of the module is D10 compatible, then proceed with targeting D11.

I just looked at the D10 issue and closed it as outdated. The module is definitely D10 compatible already and I found the commit that made it so: https://git.drupalcode.org/project/media_acquiadam/-/commit/2222111cb933...

It was handled in a custom issue tracker.

I think we can un-postpone.

This module requires fallback_formatter which has not yet released any D11-compatible version. Follow 📌 Automated Drupal 11 compatibility fixes for fallback_formatter Needs review for further updates.

baluertl → closed merge request !22

Automatically closed - issue fixed for 2 weeks with no activity.