- Status changed to Needs work
about 1 year ago 4:04pm 9 May 2023 - 🇺🇸United States mglaman WI, USA
+++ b/src/Plugin/Linkit/Substitution/DAMAsset.php @@ -85,7 +85,7 @@ class DAMAsset extends Media { // @phpstan-ignore-next-line - $generated_url = file_create_url($file->getFileUri()); + $generated_url = \Drupal::service('file_url_generator')->generateAbsoluteString($file->getFileUri()); +++ b/src/Service/AssetFileEntityHelper.php @@ -431,7 +431,7 @@ class AssetFileEntityHelper implements ContainerInjectionInterface { - return file_save_data($data, $destination, FileSystemInterface::EXISTS_REPLACE); + return \Drupal::service('file.repository')->writeData($data, $destination, FileSystemInterface::EXISTS_REPLACE);
These do not need to be changed.
- last update
about 1 year ago 65 pass - @shivam_tiwari opened merge request.
- Status changed to Needs review
about 1 year ago 12:39pm 10 May 2023 - last update
about 1 year ago 51 pass, 3 fail This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module → , even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.15.1, cannot fix all Drupal 10 compatibility problems.
Therefore this patch does not update the
info.yml
file for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
Bot run #12554This patch was created using these packages:
- mglaman/phpstan-drupal: 1.1.35
- palantirnet/drupal-rector: 0.15.1
The last submitted patch, 14: media_acquiadam.2.x-dev.rector.patch, failed testing. View results →
- last update
11 months ago Patch Failed to Apply