Contrib.social

Automated Drupal 11 compatibility fixes for fallback_formatter

Open on Drupal.org →
Created on 17 March 2024, 9 months ago
Updated 12 September 2024, 3 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @project update bot
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 9 months ago
    Composer require failure
  • Comment 9 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug info

    Bot run #11-121090

    This patch was created using these packages:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.7
    3. palantirnet/drupal-rector: 0.20.1
  • Merge request !2Automated Project Update Bot fixes → (Open) created by project update bot
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 9 months ago
    Composer require failure
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 7 months ago
    Composer require failure
  • Comment 7 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-188138

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.2
    2. mglaman/phpstan-drupal: 1.2.11
    3. palantirnet/drupal-rector: 0.20.2
  • Merge request !3Draft: Automated Project Update Bot fixes → (Open) created by project update bot
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 7 months ago
    Not currently mergeable.
  • Status changed to Needs work 5 months ago
  • Comment 5 months ago →
    🇮🇳India vipin.mittal18 Greater Noida
  • Comment 5 months ago →
    🇭🇺Hungary Balu Ertl Budapest 🇪🇺

    Balu Ertl → changed the visibility of the branch project-update-bot-only to hidden.

  • Merge request !5Fixes added manually on top of bot's changes → (Merged) created by Balu Ertl
  • Pipeline finished with Failed
    5 months ago
    Total: 138s
    #227792
  • Pipeline finished with Success
    5 months ago
    Total: 996s
    #228927
  • Pipeline finished with Success
    5 months ago
    Total: 140s
    #228947
  • Status changed to Needs review 5 months ago
  • Comment 5 months ago →
    🇭🇺Hungary Balu Ertl Budapest 🇪🇺
  • Pipeline finished with Failed
    4 months ago
    #269176
  • First commit to issue fork.
  • Pipeline finished with Failed
    4 months ago
    #269177
  • Pipeline finished with Canceled
    4 months ago
    Total: 204s
    #269183
  • Pipeline finished with Success
    4 months ago
    Total: 342s
    #269189
  • Comment 4 months ago →
    🇮🇳India rajeshreeputra Pune

    Please review.

  • Pipeline finished with Failed
    4 months ago
    #271269
  • Pipeline finished with Success
    4 months ago
    Total: 168s
    #272250
  • Status changed to Needs work 4 months ago
  • Comment 4 months ago →
    🇺🇸United States phenaproxima Massachusetts

    Looks pretty good, just a few questions.

  • Status changed to Needs review 4 months ago
  • Comment 4 months ago →
    🇮🇳India rajeshreeputra Pune

    Updated MR as per review feedback, hence requesting review.

  • Pipeline finished with Success
    4 months ago
    Total: 4867s
    #273418
  • Status changed to Needs work 4 months ago
  • Comment 4 months ago →
    🇺🇸United States phenaproxima Massachusetts

    It looks like there's a concerning test failure in the "test-only changes" job: https://git.drupalcode.org/issue/fallback_formatter-3430427/-/jobs/26451...

    We should probably have that passing before we can merge this.

    I have a question: were the test changes necessary for D11 compatibility? If not, we may want to revert those as well.

  • Pipeline finished with Failed
    4 months ago
    Total: 143s
    #273643
  • Pipeline finished with Failed
    3 months ago
    Total: 179s
    #277908
  • Pipeline finished with Failed
    3 months ago
    Total: 146s
    #278085
  • Pipeline finished with Failed
    3 months ago
    Total: 307s
    #278108
  • Pipeline finished with Failed
    3 months ago
    Total: 199s
    #278122
  • Pipeline finished with Failed
    3 months ago
    Total: 169s
    #278135
  • Pipeline finished with Success
    3 months ago
    Total: 167s
    #278148
  • First commit to issue fork.
  • Pipeline finished with Running
    3 months ago
    #278857
  • Status changed to RTBC 3 months ago
  • Comment 3 months ago →
    🇺🇸United States japerry KVUO

    There were some other issues like removing 9.5 support and other seemingly linting issues which shouldn't (probably) be part of this commit. But otherwise, tests are passing (in both gitlab ci and locally for me across my 9.5, 10.3, and 11 sites) -- so RTBC?

  • Pipeline finished with Success
    3 months ago
    #278876
  • Comment 3 months ago →
    🇺🇸United States japerry KVUO

    After looking at the remaining linting issues, this module and those linting issues are so simple that despite my usual cursing against linting with compatibility, I went ahead and pushed a 'linting' commit.

    I also pushed a commit removing the legacy travis.yml and corresponding config readme info (pointing here instead)

    If you disagree, feel free to revert the 2 commits. But otherwise, tests and lints are now passing.

  • Pipeline finished with Success
    3 months ago
    Total: 160s
    #278925
  • Comment 3 months ago →
    🇺🇸United States phenaproxima Massachusetts
  • Pipeline finished with Skipped
    3 months ago
    #281603
  • Comment 3 months ago →
    System Message
  • Status changed to Fixed 3 months ago
  • Comment 3 months ago →
    🇺🇸United States phenaproxima Massachusetts

    Merged. Leaving this open, and needing work, for a follow-up to drop Drupal 9 support.

  • Comment 3 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024