Contrib.social

Automated Drupal 11 compatibility fixes for layout_builder_iframe_modal

Open on Drupal.org →
Created on 18 March 2024, 9 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Needs review

Version

1.3

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @project update bot
  • Comment 9 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug info

    Bot run #11-121090

    This patch was created using these packages:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.7
    3. palantirnet/drupal-rector: 0.20.1
  • Comment 7 months ago →
    🇺🇸United States mark_fullmer Tucson

    I did some additional auditing and analysis of the codebase for Drupal 11 compatibility. Overall, this looks like it should be pretty straightforward!

    Composer

    • [ ] This module has a composer.json file. Manually review it for Drupal 11 compatibility, such as external requirements, core version constraints, and PHP version constraints

    PHPStan Audit of Drupal deprecations

     [OK] No errors

    Drupal-Rector Audit of Drupal deprecations

     [OK] Rector is done!

    Audit of deprecated PHP <8.3 calls

    If no errors are listed below, php-compatibility did not find any.

    ........ 8 / 8 (100%)


Time: 51ms; Memory: 8MB

    jQuery 4 compatibility: List of all custom JavaScript files

    Any files listed below should be reviewed for jQuery 4 compatibility

    web/modules/contrib/layout_builder_iframe_modal/js/iframe.js
web/modules/contrib/layout_builder_iframe_modal/js/redirect.js

    Diff for updating coreversionrequirement

    diff --git a/layout_builder_iframe_modal.info.yml b/layout_builder_iframe_modal.info.yml
index 3c52813..143ec43 100644
--- a/layout_builder_iframe_modal.info.yml
+++ b/layout_builder_iframe_modal.info.yml
@@ -1,7 +1,7 @@
 name: Layout Builder iFrame Modal
 type: module
 description: 'Render Layout Builder edit forms in an iframe'
-core_version_requirement: ^8 || ^9 || ^10
+core_version_requirement: ^10 || ^11
 lifecycle: stable
 configure: layout_builder_iframe_modal.settings
  • Status changed to Active 2 months ago
  • Comment 2 months ago →
    naveenvalecha

    Setting it to Active so that bot should spin up a new PR

  • Comment about 1 month ago →
    🇺🇸United States kevinquillen

    +1

  • Merge request !14Resolve #3431586 "D11" → (Open) created by mark_fullmer
  • Pipeline finished with Success
    11 days ago
    Total: 186s
    #347429
  • Comment 11 days ago →
    🇺🇸United States mark_fullmer Tucson

    Merge request created, demonstrating passing FunctionalJavascript tests on Drupal 10 and Drupal 11. Setting to "Needs review"!

  • Comment 6 days ago →
    🇺🇸United States mmarler

    Tested in Drupal 10.3.10 and 11.0.9. Setting to RTBC.

  • Status changed to RTBC 6 days ago
  • Comment 6 days ago →
    🇺🇸United States mmarler
  • Comment 2 days ago →
    🇧🇪Belgium svendecabooter Gent

    Looks good to me.
    Hopefully a new D11-compatible release can be tagged soon by the maintainers.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024