- Issue created by @project update bot
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module โ , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.
Therefore these changes did not update the
info.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot โ to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug info
Bot run #11-121090This patch was created using these packages:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.7
- palantirnet/drupal-rector: 0.20.1
This comment was forced and has ignored the check if a change was already posted. This is only done when we want to update the issue without waiting for changes to happen.
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module โ , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.
Therefore, these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot โ to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-137198These packages were used to generate the fixes:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.10
- palantirnet/drupal-rector: 0.20.1
- ๐ฎ๐ณIndia vishalkhode
vishalkhode โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia vishalkhode
vishalkhode โ changed the visibility of the branch 3431484-automated-drupal-11 to hidden.
- ๐ฎ๐ณIndia vishalkhode
vishalkhode โ changed the visibility of the branch 3431484-automated-drupal-11 to active.
- ๐ฎ๐ณIndia vishalkhode
vishalkhode โ changed the visibility of the branch project-update-bot-only to hidden.
- ๐ฎ๐ณIndia vishalkhode
The MR is ready for review. CI is green and all PHPUnit tests are passing.
- First commit to issue fork.
- Status changed to RTBC
7 months ago 11:33am 28 May 2024 - ๐ฎ๐ณIndia ankitv18
Added the OPT_IN_TEST_NEXT_MAJOR in the gitlab file to run the CI job for D11,
Reviewed the MR, changes looking fine to me ~~ marking this RTBC - ๐บ๐ธUnited States mglaman WI, USA
We have https://www.drupal.org/project/jsonapi_resources/issues/3362189 ๐ Implement ValueResolverInterface instead of ArgumentValueResolverInterface Active , please work on the specific fix there. It must also be backwards compatible.
- Status changed to Needs work
7 months ago 11:48am 28 May 2024 - Merge request !14Implemented ValueResolverInterface instead of ArgumentValueResolverInterface. โ (Closed) created by vishalkhode
- ๐ฎ๐ณIndia vishalkhode
vishalkhode โ changed the visibility of the branch 3362189-implement-valueresolverinterface-instead to hidden.
- Status changed to Needs review
6 months ago 3:38am 23 June 2024 - Status changed to RTBC
6 months ago 3:43am 23 June 2024 - ๐ฏ๐ตJapan ptmkenny
Downloaded MR 13 locally and upgraded the module. Accessed JSON Resources on my site; everything was fine.
Ran Upgrade Status scan, which reported one error:
web/modules/jsonapi_resources/src/Unstable/Value/NewResourceObject.php 24 Class Drupal\jsonapi_resources\Unstable\Value\NewResourceObject extends @internal class Drupal\jsonapi\JsonApiResource\ResourceObject.
I assume this is fine because it's already an issue with the existing code and not something unique that needs to be addressed specifically for D11.
- ๐บ๐ธUnited States mglaman WI, USA
Thanks for checking @ptmkenny. Looks like it's mostly test related, thanks for BC shim for trait.
-
mglaman โ
committed 64f6abb9 on 8.x-1.x authored by
vishalkhode โ
Issue #3431484 by vishalkhode, ankitv18, ptmkenny: Automated Drupal 11...
-
mglaman โ
committed 64f6abb9 on 8.x-1.x authored by
vishalkhode โ
- Status changed to Fixed
6 months ago 9:31pm 25 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.