- Issue created by @project update bot
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module β , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.
Therefore these changes did not update the
info.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot β to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug info
Bot run #11-121090This patch was created using these packages:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.7
- palantirnet/drupal-rector: 0.20.1
- Status changed to Needs review
about 1 year ago 11:55am 17 March 2024 This comment was forced and has ignored the check if a change was already posted. This is only done when we want to update the issue without waiting for changes to happen.
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module β , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.
Therefore, these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot β to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-137198These packages were used to generate the fixes:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.10
- palantirnet/drupal-rector: 0.20.1
- First commit to issue fork.
- πΊπΈUnited States BenStallings
I can verify that MR!97 can be installed & enabled in Drupal 11.
- π©πͺGermany jurgenhaas Gottmadingen
Would be important to get some Drupal 11 support.
- π©πͺGermany jurgenhaas Gottmadingen
Thanks @grimreaper for the heads-up, I've now scanned the whole module and not only found the other info files that needed updating, but also a few deprecations where the used functions don't exist in D11 any longer.
I've fixed all that, but that now requires a decision as the next release can no longer support older Drupal 10 or even Drupal 9 sites. My recommendation is to support
^10.3 || ^11
, as most modules are doing that successfully. And everything before Drupal 10.3 is not supported any longer. If any user wanted to stay on any of those core versions, they would have to continue with an older version of entity_share. - π«π·France Grimreaper France π«π·
Thanks a lot, the previous version of the MR had too few changes in my opinion, with your last push I am way more confident.
No problem for the minimum version update. I am too in favor of "once it is no more supported, it should not require a new major version".
I will merge and if new problems are found it can be fixed in follow up issues.
-
grimreaper β
committed 543a0f19 on 8.x-3.x authored by
benstallings β
Issue #3430243 by project update bot, benstallings, jurgenhaas,...
-
grimreaper β
committed 543a0f19 on 8.x-3.x authored by
benstallings β
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
13 days ago 11:15am 20 March 2025 - πΊπ¦Ukraine v.dovhaliuk
The patch file has been provided since using MR as a patch is a security issue.
- π©πͺGermany jurgenhaas Gottmadingen
Using a patch file from d.o is likewise not recommended, you can not rely on those files being present. The correct way is to download the diff and patch from local files. And you can get that diff from the MR without any issue.