- Issue created by @project update bot
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module β these changes make this module compatible with Drupal 11! π
Therefore these changes update theinfo.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot β to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug info
Bot run #11-120835This patch was created using these packages:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.7
- palantirnet/drupal-rector: 0.20.1
After running drupal/upgrade_status and Rector on a D10.3.5 instance + installing the module on a fresh D11, I can confirm that the automatically provided patch is enough to provide D11 compatibility.
- First commit to issue fork.
- π©πͺGermany Anybody Porta Westfalica
@misterdidi thank you!
Regarding
Static call instead of dependency injection in EntityController.php : In getEntity() method, \Drupal::request() was called. Since this method is called from a route subscriber, the request can be passed as an input parameter to prevent the static call.
did you check that the change on getEntity() parameters is backwards compatible? If yes, this LGTM!
- π©πͺGermany Anybody Porta Westfalica
Use
composer require 'drupal/convert_bundles:2.0.x-dev@dev'
to install the dev version in D11. - π©πͺGermany Grevil
https://git.drupalcode.org/project/convert_bundles/-/merge_requests/23 now only contains the changes by @misterdidi, but not the actual module info file compatibility changes.
- π©πͺGermany Grevil
That should be it. Although this could be more seen as a cleanup issue now, as dev is already d11 compatible.
- π©πͺGermany Anybody Porta Westfalica
Thanks @grevil! RTBC! Afterwards a new stable release should be tagged :)
- First commit to issue fork.
-
misterdidi β
committed ff84148f on 3.0.x
Issue #3429567: D11 compatibility, phpstan issues fixes
-
misterdidi β
committed ff84148f on 3.0.x
- π¨π¦Canada joseph.olstad
D11 compatibility was merged into the 2.0.x branch a while ago, forgot to publish a tag though.
What's the difference between 2.0.x and 3.0.x? Why the new branch?
Should explain this in the project page or release notes and README.md.
We've been using 2.0.x-dev with Drupal 11 for a few months now , not sure how extensively it's been used but it's deployed in production since a few months and I haven't heard of any complaints yet.